From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65273C19F2D for ; Tue, 9 Aug 2022 09:12:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231360AbiHIJMI (ORCPT ); Tue, 9 Aug 2022 05:12:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230508AbiHIJMG (ORCPT ); Tue, 9 Aug 2022 05:12:06 -0400 Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFE2821808 for ; Tue, 9 Aug 2022 02:12:04 -0700 (PDT) Received: by mail-pf1-x42d.google.com with SMTP id h28so10236661pfq.11 for ; Tue, 09 Aug 2022 02:12:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=rnKvsjRzjSZVAjcLrYl/OIdjQK2uj+t6rJ77SSO6CMM=; b=UEOGGaqvsR2p1jHsaMP0Hmr/dYjSZxADudKeomtqEELhb112451c4ixhOoRdxhPh9A O9uFbOEeInN1y5q2uQK6VLjGjFItGb91DpDzAtToWtlhn64ekTEJmoKmWtiTPleEeKvO 6NJwgOOxwh99JVSXVCjE5YDMKPnR3WWnO/kDM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=rnKvsjRzjSZVAjcLrYl/OIdjQK2uj+t6rJ77SSO6CMM=; b=oi0fLEvvv5ufZzzY5T669tDDpWaxVLjReRI2gsPmPVJdiTSRkce0neQLLs5H73tn+N zzvlpENeINOWYZc915/7rf+1RtYcnYxGCRt4ICM2/j7R04P7q+vWhMJS6aRnvUWukRvE lNmL+LyRYQk36y9oG/2beqp3S198yvAk+qVB2U/ldD7lRoqQl9Bt3zl3/6Hktpx3qNar RI/60lI7Lr343LEUqPHeHkTj/l+yocOlVLmoxJJ28WRNu3Hy5g52RhJvz7QSNwQsw/si Aql1VB6vosjHb8pTYjrKJkd6eJ9pye9RVgF3ePLHyFATVt7gOVHXxzuzbwBtVYinwOnG nnaA== X-Gm-Message-State: ACgBeo1B1JhNST2NU/XTnM8MGWEqS7TG5Ol+IGAyP++SZxqSWRW8HBHr 2puPs4xsN50FwsApzsD8SqFKhQ== X-Google-Smtp-Source: AA6agR4YjfpNeCgdxVd1yQ8AWTKp3oIXYofRkuKCvkMGshMjI+ND2ooQKLj8EiTWOCP7BNCp3BDxgQ== X-Received: by 2002:a63:6d2:0:b0:41c:18f2:8ec5 with SMTP id 201-20020a6306d2000000b0041c18f28ec5mr19158344pgg.197.1660036324302; Tue, 09 Aug 2022 02:12:04 -0700 (PDT) Received: from google.com ([240f:75:7537:3187:8d43:c739:457a:5504]) by smtp.gmail.com with ESMTPSA id t3-20020a1709027fc300b0016daee46b72sm10195159plb.237.2022.08.09.02.12.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Aug 2022 02:12:03 -0700 (PDT) Date: Tue, 9 Aug 2022 18:11:57 +0900 From: Sergey Senozhatsky To: Jiri Slaby Cc: Linus Torvalds , Linux Kernel Mailing List , minchan@kernel.org, ngupta@vflare.org, Jan Kara , Ted Ts'o , Andreas Dilger , Ext4 Developers List , avromanov@sberdevices.ru, ddrokosov@sberdevices.ru, Sergey Senozhatsky Subject: Re: ext2/zram issue [was: Linux 5.19] Message-ID: References: <702b3187-14bf-b733-263b-20272f53105d@kernel.org> <8710b302-9415-458d-f8a2-b78cc3a96e49@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On (22/08/09 17:43), Sergey Senozhatsky wrote: > On (22/08/09 10:12), Jiri Slaby wrote: > > > So currently, I blame: > > > commit e7be8d1dd983156bbdd22c0319b71119a8fbb697 > > > Author: Alexey Romanov > > > Date:   Thu May 12 20:23:07 2022 -0700 > > > > > >     zram: remove double compression logic > > > > > > > > > /me needs to confirm. > > > > With that commit reverted, I see no more I/O errors, only oom-killer > > messages (which is OK IMO, provided I write 1G of urandom on a machine w/ > > 800M of RAM): > > Hmm... So handle allocation always succeeds in the slow path? (when we > try to allocate it second time) Yeah I can see how handle re-allocation with direct reclaim can make it more successful, but in exchange it oom-kills some user-space process, I suppose. Is oom-kill really a good alternative though?