From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05B58C19F2D for ; Tue, 9 Aug 2022 11:53:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242835AbiHILxq (ORCPT ); Tue, 9 Aug 2022 07:53:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241223AbiHILxo (ORCPT ); Tue, 9 Aug 2022 07:53:44 -0400 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94FAD2408E for ; Tue, 9 Aug 2022 04:53:43 -0700 (PDT) Received: by mail-pj1-x1033.google.com with SMTP id b4so11429360pji.4 for ; Tue, 09 Aug 2022 04:53:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=MhTAURSUPBWnaSKcyWKFU+A5UniE5HexPukkaWbzBMw=; b=FjQ/OY5s6aMvHaS8BQfv9lipYuJ8oh5mpIbsWWiiZipMBaLtTKF7pbtW4N/0E0Qoq4 vVkZ4esXrmnUkYwvzaonRLUhwHwYG8rZDzlVNVvSQBOAC5DgNzDSRTEZr8Y2lGB9Tr+U 74jEtBQLLRTlx8IGV+D1pYUDwdzk52apOLfEU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=MhTAURSUPBWnaSKcyWKFU+A5UniE5HexPukkaWbzBMw=; b=yGUIiIWDy0mARrTfvbUoXJyFDtV54i5bF3Mh6koDA7sZaKBdCbTitcuvQT4pDXFeRL gMauDKlTf6HQLQXJkVHd2TTF6Hf7ZEkjN0kK0oVy/N9opNYxBeqONsNQ9Bhk3uEbaUAX N5BhRDSgumCzY/9GUh6/wL8i7Q8L8PRpL82/h1IokDuou4/mRBMjJ5sKf9k0aIatgpOD y28Agcc3ZeMCBBDyXhE8Xr6lOH14xbNUZoJX1HNAfh8XVTxHaRorpn7RpnbrAuWYQ9qT fD5vHYCxqAgq/Pa5RZqRLI/T7/wIIiAw7eM0Mwt40oolMgyky322AlDF1rcRb8DiJWvi JoIQ== X-Gm-Message-State: ACgBeo2ngHlWs1zgP906aAvlPwAXXVD6AW27nFGzvm66+v7IRGuBpbti dnCnUX7YPlIFPbqiikW/nF1kZYQ5ESpKrA== X-Google-Smtp-Source: AA6agR7rZ3dTXq9ibr+gEUNA/cDz++UWqyPCabykB2g95Xh4p0CPVkGX38yR0PZOG9r4eH7jqICBFQ== X-Received: by 2002:a17:903:2685:b0:16e:da0a:9d8 with SMTP id jf5-20020a170903268500b0016eda0a09d8mr22828317plb.42.1660046022969; Tue, 09 Aug 2022 04:53:42 -0700 (PDT) Received: from google.com ([240f:75:7537:3187:8d43:c739:457a:5504]) by smtp.gmail.com with ESMTPSA id nm8-20020a17090b19c800b001f2fa09786asm9967720pjb.19.2022.08.09.04.53.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Aug 2022 04:53:42 -0700 (PDT) Date: Tue, 9 Aug 2022 20:53:36 +0900 From: Sergey Senozhatsky To: Dmitry Rokosov , Jiri Slaby , Minchan Kim Cc: Sergey Senozhatsky , Jiri Slaby , Linus Torvalds , Linux Kernel Mailing List , "ngupta@vflare.org" , Jan Kara , Ted Ts'o , Andreas Dilger , Ext4 Developers List , Aleksey Romanov Subject: Re: ext2/zram issue [was: Linux 5.19] Message-ID: References: <702b3187-14bf-b733-263b-20272f53105d@kernel.org> <8710b302-9415-458d-f8a2-b78cc3a96e49@kernel.org> <20220809102011.pfhfb4k7tdkqvdai@CAB-WSD-L081021.sigma.sbrf.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220809102011.pfhfb4k7tdkqvdai@CAB-WSD-L081021.sigma.sbrf.ru> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Hi, On (22/08/09 10:20), Dmitry Rokosov wrote: > I think oom-kill is an inevitable escape from low memory situation if we > don't solve original problem with high memory consumption in the user > setup. Reclaim-based zram slow path just delays oom if memory eating > root cause is not resolved. > > I totally agree with you that all patches which have visible user > degradations should be reverted, but maybe this is more user setup > problem, what do you think? I'd go with the revert. Jiri, are you going to send the revert patch or shall I handle it? > If you make the decision to revert slow path removal patch, I would > prefer to review the original patch with unneeded code removal again > if you don't mind: > https://lore.kernel.org/linux-block/20220422115959.3313-1-avromanov@sberdevices.ru/ Sure, we can return to it after the merge window.