* [PATCH 5.19] Documentation: ext4: fix cell spacing of table heading on blockmap table
@ 2022-08-09 8:08 Bagas Sanjaya
2022-08-09 15:03 ` Darrick J. Wong
0 siblings, 1 reply; 4+ messages in thread
From: Bagas Sanjaya @ 2022-08-09 8:08 UTC (permalink / raw)
To: linux-doc
Cc: Bagas Sanjaya, stable, Andreas Dilger, Jonathan Corbet,
Wang Jianjian, linux-ext4, linux-kernel, Theodore Ts'o
commit 442ec1e5bb7c46c72c41898e13a5744c84cadf51 upstream.
Commit 3103084afcf234 ("ext4, doc: remove unnecessary escaping") removes
redundant underscore escaping, however the cell spacing in heading row of
blockmap table became not aligned anymore, hence triggers malformed table
warning:
Documentation/filesystems/ext4/blockmap.rst:3: WARNING: Malformed table.
+---------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| i.i_block Offset | Where It Points |
<snipped>...
The warning caused the table not being loaded.
Realign the heading row cell by adding missing space at the first cell
to fix the warning.
Fixes: 3103084afcf234 ("ext4, doc: remove unnecessary escaping")
Cc: stable@kernel.org
Cc: Andreas Dilger <adilger.kernel@dilger.ca>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Wang Jianjian <wangjianjian3@huawei.com>
Cc: linux-ext4@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
Link: https://lore.kernel.org/r/20220619072938.7334-1-bagasdotme@gmail.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
---
Seems like this patch is merged to Linus's tree as merge window
material for 6.0, but it should have been -rc fix material for 5.19
cycle. Now that the version have been stabilized (and now on 6.0 merge
window), it should be logical to submit this backport for 5.19 tree.
Documentation/filesystems/ext4/blockmap.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/filesystems/ext4/blockmap.rst b/Documentation/filesystems/ext4/blockmap.rst
index 2bd990402a5c49..cc596541ce7921 100644
--- a/Documentation/filesystems/ext4/blockmap.rst
+++ b/Documentation/filesystems/ext4/blockmap.rst
@@ -1,7 +1,7 @@
.. SPDX-License-Identifier: GPL-2.0
+---------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
-| i.i_block Offset | Where It Points |
+| i.i_block Offset | Where It Points |
+=====================+==============================================================================================================================================================================================================================+
| 0 to 11 | Direct map to file blocks 0 to 11. |
+---------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
--
An old man doll... just what I always wanted! - Clara
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 5.19] Documentation: ext4: fix cell spacing of table heading on blockmap table
2022-08-09 8:08 [PATCH 5.19] Documentation: ext4: fix cell spacing of table heading on blockmap table Bagas Sanjaya
@ 2022-08-09 15:03 ` Darrick J. Wong
2022-08-09 17:59 ` Theodore Ts'o
0 siblings, 1 reply; 4+ messages in thread
From: Darrick J. Wong @ 2022-08-09 15:03 UTC (permalink / raw)
To: Bagas Sanjaya
Cc: linux-doc, stable, Andreas Dilger, Jonathan Corbet, Wang Jianjian,
linux-ext4, linux-kernel, Theodore Ts'o
On Tue, Aug 09, 2022 at 03:08:28PM +0700, Bagas Sanjaya wrote:
> commit 442ec1e5bb7c46c72c41898e13a5744c84cadf51 upstream.
>
> Commit 3103084afcf234 ("ext4, doc: remove unnecessary escaping") removes
> redundant underscore escaping, however the cell spacing in heading row of
> blockmap table became not aligned anymore, hence triggers malformed table
> warning:
>
> Documentation/filesystems/ext4/blockmap.rst:3: WARNING: Malformed table.
>
> +---------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
> | i.i_block Offset | Where It Points |
> <snipped>...
>
> The warning caused the table not being loaded.
>
> Realign the heading row cell by adding missing space at the first cell
> to fix the warning.
>
> Fixes: 3103084afcf234 ("ext4, doc: remove unnecessary escaping")
> Cc: stable@kernel.org
> Cc: Andreas Dilger <adilger.kernel@dilger.ca>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: Wang Jianjian <wangjianjian3@huawei.com>
> Cc: linux-ext4@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
> Link: https://lore.kernel.org/r/20220619072938.7334-1-bagasdotme@gmail.com
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
> ---
>
> Seems like this patch is merged to Linus's tree as merge window
> material for 6.0, but it should have been -rc fix material for 5.19
> cycle. Now that the version have been stabilized (and now on 6.0 merge
> window), it should be logical to submit this backport for 5.19 tree.
>
> Documentation/filesystems/ext4/blockmap.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/filesystems/ext4/blockmap.rst b/Documentation/filesystems/ext4/blockmap.rst
> index 2bd990402a5c49..cc596541ce7921 100644
> --- a/Documentation/filesystems/ext4/blockmap.rst
> +++ b/Documentation/filesystems/ext4/blockmap.rst
> @@ -1,7 +1,7 @@
> .. SPDX-License-Identifier: GPL-2.0
>
> +---------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
> -| i.i_block Offset | Where It Points |
> +| i.i_block Offset | Where It Points |
AHA, that's why I kept getting screenfuls of sphinx complaints when I
was building the XFS documentation. Thanks for fixing this...
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> +=====================+==============================================================================================================================================================================================================================+
> | 0 to 11 | Direct map to file blocks 0 to 11. |
> +---------------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
> --
> An old man doll... just what I always wanted! - Clara
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 5.19] Documentation: ext4: fix cell spacing of table heading on blockmap table
2022-08-09 15:03 ` Darrick J. Wong
@ 2022-08-09 17:59 ` Theodore Ts'o
2022-08-10 8:24 ` Bagas Sanjaya
0 siblings, 1 reply; 4+ messages in thread
From: Theodore Ts'o @ 2022-08-09 17:59 UTC (permalink / raw)
To: Darrick J. Wong
Cc: Bagas Sanjaya, linux-doc, stable, Andreas Dilger, Jonathan Corbet,
Wang Jianjian, linux-ext4, linux-kernel
Begas,
You sent me a patch to address this and it's fixed upstream, landing
in Linus's tree after 5.19 release during the current merge window.
It's cc'ed to stable@kernel.org, so it's not necessary for you to send
it to stable@ as a separate patch.
This upstream commit is 442ec1e5bb7c ("Documentation: ext4: fix cell
spacing of table heading on blockmap table").
- Ted
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 5.19] Documentation: ext4: fix cell spacing of table heading on blockmap table
2022-08-09 17:59 ` Theodore Ts'o
@ 2022-08-10 8:24 ` Bagas Sanjaya
0 siblings, 0 replies; 4+ messages in thread
From: Bagas Sanjaya @ 2022-08-10 8:24 UTC (permalink / raw)
To: Theodore Ts'o, Darrick J. Wong
Cc: linux-doc, stable, Andreas Dilger, Jonathan Corbet, Wang Jianjian,
linux-ext4, linux-kernel
On 8/10/22 00:59, Theodore Ts'o wrote:
> Begas,
>
> You sent me a patch to address this and it's fixed upstream, landing
> in Linus's tree after 5.19 release during the current merge window.
> It's cc'ed to stable@kernel.org, so it's not necessary for you to send
> it to stable@ as a separate patch.
>
> This upstream commit is 442ec1e5bb7c ("Documentation: ext4: fix cell
> spacing of table heading on blockmap table").
>
> - Ted
Hi Ted, thanks for reminding me.
As stated earlier, I was wonder why 442ec1e5bb7c is applied as 6.0 merge
window material, although the problem had been identified in 5.19 release
cycle.
--
An old man doll... just what I always wanted! - Clara
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-10 8:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-09 8:08 [PATCH 5.19] Documentation: ext4: fix cell spacing of table heading on blockmap table Bagas Sanjaya
2022-08-09 15:03 ` Darrick J. Wong
2022-08-09 17:59 ` Theodore Ts'o
2022-08-10 8:24 ` Bagas Sanjaya
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).