From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: guaneryu@gmail.com, zlang@redhat.com, linux-xfs@vger.kernel.org,
fstests@vger.kernel.org, guan@eryu.me, tytso@mit.edu,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/3] common/rc: move ext4-specific helpers into a separate common/ext4 file
Date: Thu, 11 Aug 2022 05:32:02 -0700 [thread overview]
Message-ID: <YvT2wslkHNKKuDY8@infradead.org> (raw)
In-Reply-To: <166007884681.3276300.8815951431509313240.stgit@magnolia>
On Tue, Aug 09, 2022 at 02:00:46PM -0700, Darrick J. Wong wrote:
> --- a/common/config
> +++ b/common/config
> @@ -512,6 +512,10 @@ _source_specific_fs()
> ;;
> ext4)
> [ "$MKFS_EXT4_PROG" = "" ] && _fatal "mkfs.ext4 not found"
> + . ./common/ext4
> + ;;
> + ext2|ext3|ext4dev)
> + . ./common/ext4
Not really new in this patch, but why does ext4 check for a specific
mkfs and the others don't?
Also can we drop ext4dev while we're at it?
The patch itself looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2022-08-11 12:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-09 21:00 [PATCHSET v2 0/3] fstests: refactor ext4-specific code Darrick J. Wong
2022-08-09 21:00 ` [PATCH 1/3] common/rc: move ext4-specific helpers into a separate common/ext4 file Darrick J. Wong
2022-08-11 12:32 ` Christoph Hellwig [this message]
2022-08-09 21:00 ` [PATCH 2/3] common/rc: move XFS-specific parts of _scratch_options into common/xfs Darrick J. Wong
2022-08-11 12:32 ` Christoph Hellwig
2022-08-09 21:00 ` [PATCH 3/3] common/ext4: provide custom ext4 scratch fs options Darrick J. Wong
2022-08-11 12:32 ` Christoph Hellwig
2022-08-15 9:18 ` [PATCHSET v2 0/3] fstests: refactor ext4-specific code Zorro Lang
-- strict thread matches above, loose matches on Subject: below --
2022-08-03 4:21 [PATCHSET " Darrick J. Wong
2022-08-03 4:21 ` [PATCH 1/3] common/rc: move ext4-specific helpers into a separate common/ext4 file Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvT2wslkHNKKuDY8@infradead.org \
--to=hch@infradead.org \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=guaneryu@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).