From: "Theodore Ts'o" <tytso@mit.edu>
To: Andreas Dilger <adilger@dilger.ca>
Cc: linux-ext4@vger.kernel.org, Dongyang Li <dongyang@ddn.com>
Subject: Re: [PATCH] debugfs: quiet debugfs 'catastrophic' message
Date: Fri, 12 Aug 2022 21:11:47 -0400 [thread overview]
Message-ID: <Yvb6UzeX2Umg1ts+@mit.edu> (raw)
In-Reply-To: <20220805220606.11994-1-adilger@dilger.ca>
On Fri, Aug 05, 2022 at 04:06:07PM -0600, Andreas Dilger wrote:
> When debugfs runs with "-c", it prints a scary-looking message:
>
> catastrophic mode - not reading inode or group bitmaps
>
> that is often misunderstood by users to mean that there is something
> wrong with the filesystem, when there is no problem at all.
>
> Not reading the bitmaps is totally normal and expected behavior for
> the "-c" option, which is used to significantly shorten the debugfs
> command execution time by not reading metadata that isn't needed for
> commands run against very large filesystems.
>
> Since there is often confusion about what this message means, it
> would be better to just avoid printing anything at all, since the
> use of "-c" is expressly requesting this behavior, and there are
> no messages printed out for other options.
>
> Signed-off-by: Andreas Dilger <adilger@dilger.ca>
> Reviewed-by: Dongyang Li <dongyang@ddn.com>
> Change-Id: I59b26a601780544ab995aa4ca7ab0c2123c70118
Applied, thanks!
- Ted
prev parent reply other threads:[~2022-08-13 1:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 22:06 [PATCH] debugfs: quiet debugfs 'catastrophic' message Andreas Dilger
2022-08-13 1:11 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yvb6UzeX2Umg1ts+@mit.edu \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=dongyang@ddn.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).