From: Eric Biggers <ebiggers@kernel.org>
To: Gabriel Krisman Bertazi <krisman@collabora.com>
Cc: tytso@mit.edu, adilger.kernel@dilger.ca, jaegeuk@kernel.org,
linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, kernel@collabora.com
Subject: Re: [PATCH v9 4/8] ext4: Reuse generic_ci_match for ci comparisons
Date: Thu, 22 Sep 2022 20:48:44 -0700 [thread overview]
Message-ID: <Yy0snGZYtLKtORT7@sol.localdomain> (raw)
In-Reply-To: <20220913234150.513075-5-krisman@collabora.com>
On Tue, Sep 13, 2022 at 07:41:46PM -0400, Gabriel Krisman Bertazi wrote:
> Instead of reimplementing ext4_match_ci, use the new libfs helper.
>
> It also adds a comment explaining why fname->cf_name.name must be
> checked prior to the encryption hash optimization, because that tripped
> me before.
>
> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>
Reviewed-by: Eric Biggers <ebiggers@google.com>
- Eric
next prev parent reply other threads:[~2022-09-23 3:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-13 23:41 [PATCH v9 0/8] Clean up the case-insensitive lookup path Gabriel Krisman Bertazi
2022-09-13 23:41 ` [PATCH v9 1/8] ext4: Simplify the handling of cached insensitive names Gabriel Krisman Bertazi
2022-09-13 23:41 ` [PATCH v9 2/8] f2fs: " Gabriel Krisman Bertazi
2022-09-13 23:41 ` [PATCH v9 3/8] libfs: Introduce case-insensitive string comparison helper Gabriel Krisman Bertazi
2022-09-13 23:41 ` [PATCH v9 4/8] ext4: Reuse generic_ci_match for ci comparisons Gabriel Krisman Bertazi
2022-09-23 3:48 ` Eric Biggers [this message]
2022-09-13 23:41 ` [PATCH v9 5/8] f2fs: " Gabriel Krisman Bertazi
2022-09-13 23:41 ` [PATCH v9 6/8] ext4: Log error when lookup of encoded dentry fails Gabriel Krisman Bertazi
2022-09-13 23:41 ` [PATCH v9 7/8] ext4: Move CONFIG_UNICODE defguards into the code flow Gabriel Krisman Bertazi
2022-09-13 23:41 ` [PATCH v9 8/8] f2fs: " Gabriel Krisman Bertazi
2022-09-23 3:54 ` [PATCH v9 0/8] Clean up the case-insensitive lookup path Eric Biggers
2022-09-23 14:54 ` Gabriel Krisman Bertazi
2022-10-13 23:45 ` Gabriel Krisman Bertazi
2022-12-08 14:38 ` Muhammad Usama Anjum
2022-12-09 13:47 ` Gabriel Krisman Bertazi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yy0snGZYtLKtORT7@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=jaegeuk@kernel.org \
--cc=kernel@collabora.com \
--cc=krisman@collabora.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox