* Re: [PATCH 6.1 788/885] ext4: Fix possible corruption when moving a directory
[not found] ` <20230307170036.133148515@linuxfoundation.org>
@ 2023-03-07 19:23 ` Eric Biggers
2023-03-08 7:17 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Eric Biggers @ 2023-03-07 19:23 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: stable, patches, Jan Kara, Theodore Tso, linux-ext4
On Tue, Mar 07, 2023 at 06:02:02PM +0100, Greg Kroah-Hartman wrote:
> From: Jan Kara <jack@suse.cz>
>
> commit 0813299c586b175d7edb25f56412c54b812d0379 upstream.
>
> When we are renaming a directory to a different directory, we need to
> update '..' entry in the moved directory. However nothing prevents moved
> directory from being modified and even converted from the inline format
> to the normal format. When such race happens the rename code gets
> confused and we crash. Fix the problem by locking the moved directory.
>
> CC: stable@vger.kernel.org
> Fixes: 32f7f22c0b52 ("ext4: let ext4_rename handle inline dir")
> Signed-off-by: Jan Kara <jack@suse.cz>
> Link: https://lore.kernel.org/r/20230126112221.11866-1-jack@suse.cz
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit has a reported regression
(https://lore.kernel.org/linux-ext4/5efbe1b9-ad8b-4a4f-b422-24824d2b775c@kili.mountain),
so probably it should not be backported quite yet.
- Eric
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 6.1 788/885] ext4: Fix possible corruption when moving a directory
2023-03-07 19:23 ` [PATCH 6.1 788/885] ext4: Fix possible corruption when moving a directory Eric Biggers
@ 2023-03-08 7:17 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2023-03-08 7:17 UTC (permalink / raw)
To: Eric Biggers; +Cc: stable, patches, Jan Kara, Theodore Tso, linux-ext4
On Tue, Mar 07, 2023 at 07:23:10PM +0000, Eric Biggers wrote:
> On Tue, Mar 07, 2023 at 06:02:02PM +0100, Greg Kroah-Hartman wrote:
> > From: Jan Kara <jack@suse.cz>
> >
> > commit 0813299c586b175d7edb25f56412c54b812d0379 upstream.
> >
> > When we are renaming a directory to a different directory, we need to
> > update '..' entry in the moved directory. However nothing prevents moved
> > directory from being modified and even converted from the inline format
> > to the normal format. When such race happens the rename code gets
> > confused and we crash. Fix the problem by locking the moved directory.
> >
> > CC: stable@vger.kernel.org
> > Fixes: 32f7f22c0b52 ("ext4: let ext4_rename handle inline dir")
> > Signed-off-by: Jan Kara <jack@suse.cz>
> > Link: https://lore.kernel.org/r/20230126112221.11866-1-jack@suse.cz
> > Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> This commit has a reported regression
> (https://lore.kernel.org/linux-ext4/5efbe1b9-ad8b-4a4f-b422-24824d2b775c@kili.mountain),
> so probably it should not be backported quite yet.
Thanks, I've dropped it from everywhere now. Please let us know when
it's safe to add back to the tree.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-08 7:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230307170001.594919529@linuxfoundation.org>
[not found] ` <20230307170036.133148515@linuxfoundation.org>
2023-03-07 19:23 ` [PATCH 6.1 788/885] ext4: Fix possible corruption when moving a directory Eric Biggers
2023-03-08 7:17 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).