From: Eric Biggers <ebiggers@kernel.org>
To: Yangtao Li <frank.li@vivo.com>
Cc: tytso@mit.edu, adilger.kernel@dilger.ca,
hsiangkao@linux.alibaba.com, linux-ext4@vger.kernel.org,
linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org,
viro@zeniv.linux.org.uk
Subject: Re: [PATCH] ext4: convert to DIV_ROUND_UP() in mpage_process_page_bufs()
Date: Thu, 9 Mar 2023 22:41:01 -0800 [thread overview]
Message-ID: <ZArQ/WaBrw0LR56v@sol.localdomain> (raw)
In-Reply-To: <20230310062738.69663-1-frank.li@vivo.com>
On Fri, Mar 10, 2023 at 02:27:38PM +0800, Yangtao Li wrote:
> > Please don't do this. This makes the code compile down to a division, which is
> > far less efficient. I've verified this by checking the assembly generated.
>
> How much is the performance impact? So should the following be modified as shift operations as well?
>
> fs/erofs/namei.c:92: int head = 0, back = DIV_ROUND_UP(dir->i_size, EROFS_BLKSIZ) - 1;
> fs/erofs/zmap.c:252: const unsigned int totalidx = DIV_ROUND_UP(inode->i_size, EROFS_BLKSIZ);
> fs/erofs/decompressor.c:14:#define LZ4_MAX_DISTANCE_PAGES (DIV_ROUND_UP(LZ4_DISTANCE_MAX, PAGE_SIZE) + 1)
> fs/erofs/decompressor.c:56: DIV_ROUND_UP(distance, PAGE_SIZE) + 1 :
> fs/erofs/decompressor.c:70: unsigned long bounced[DIV_ROUND_UP(LZ4_MAX_DISTANCE_PAGES,
> fs/erofs/data.c:84: nblocks = DIV_ROUND_UP(inode->i_size, EROFS_BLKSIZ);
>
No, compilers can handle division by a power-of-2 constant just fine. It's just
division by a non-constant that is inefficient.
- Eric
next prev parent reply other threads:[~2023-03-10 6:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 6:07 [PATCH] ext4: convert to DIV_ROUND_UP() in mpage_process_page_bufs() Yangtao Li
2023-03-10 6:17 ` Eric Biggers
2023-03-10 6:27 ` Yangtao Li
2023-03-10 6:35 ` Gao Xiang
2023-03-10 6:37 ` Gao Xiang
2023-03-10 6:41 ` Eric Biggers [this message]
2023-03-10 6:37 ` Al Viro
2023-03-10 6:43 ` Al Viro
2023-03-10 6:43 ` Eric Biggers
2023-03-10 6:46 ` Al Viro
2023-03-10 6:54 ` Eric Biggers
2023-03-10 7:05 ` Al Viro
2023-03-10 7:12 ` Al Viro
2023-03-10 21:47 ` Eric Biggers
2023-03-10 19:07 ` kernel test robot
2023-03-10 19:38 ` kernel test robot
2023-03-10 23:21 ` Theodore Ts'o
2023-03-13 9:25 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZArQ/WaBrw0LR56v@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=frank.li@vivo.com \
--cc=hsiangkao@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).