From: Eric Biggers <ebiggers@kernel.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Yangtao Li <frank.li@vivo.com>,
tytso@mit.edu, adilger.kernel@dilger.ca,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4: convert to DIV_ROUND_UP() in mpage_process_page_bufs()
Date: Fri, 10 Mar 2023 13:47:38 -0800 [thread overview]
Message-ID: <ZAulevdpZg/W/JbL@sol.localdomain> (raw)
In-Reply-To: <20230310071231.GU3390869@ZenIV>
On Fri, Mar 10, 2023 at 07:12:31AM +0000, Al Viro wrote:
>
> Out of curiosity (and that's already too brittle for practical use) -
> does DIV_ROUND_UP_ULL() do any better on full example?
'DIV_ROUND_UP_ULL(i_size_read(inode), i_blocksize(inode))' works properly with
clang but not gcc. If i_blocksize() is changed to do '1U << inode->i_blkbits'
instead of '1 << inode->i_blkbits', it works with gcc too.
- Eric
next prev parent reply other threads:[~2023-03-10 21:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 6:07 [PATCH] ext4: convert to DIV_ROUND_UP() in mpage_process_page_bufs() Yangtao Li
2023-03-10 6:17 ` Eric Biggers
2023-03-10 6:27 ` Yangtao Li
2023-03-10 6:35 ` Gao Xiang
2023-03-10 6:37 ` Gao Xiang
2023-03-10 6:41 ` Eric Biggers
2023-03-10 6:37 ` Al Viro
2023-03-10 6:43 ` Al Viro
2023-03-10 6:43 ` Eric Biggers
2023-03-10 6:46 ` Al Viro
2023-03-10 6:54 ` Eric Biggers
2023-03-10 7:05 ` Al Viro
2023-03-10 7:12 ` Al Viro
2023-03-10 21:47 ` Eric Biggers [this message]
2023-03-10 19:07 ` kernel test robot
2023-03-10 19:38 ` kernel test robot
2023-03-10 23:21 ` Theodore Ts'o
2023-03-13 9:25 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAulevdpZg/W/JbL@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=frank.li@vivo.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox