From: Uladzislau Rezki <urezki@gmail.com>
To: "Paul E. McKenney" <paulmck@kernel.org>, Theodore Ts'o <tytso@mit.edu>
Cc: "Uladzislau Rezki (Sony)" <urezki@gmail.com>,
Theodore Ts'o <tytso@mit.edu>,
Joel Fernandes <joel@joelfernandes.org>,
RCU <rcu@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Oleksiy Avramchenko <oleksiy.avramchenko@sony.com>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <frederic@kernel.org>,
linux-ext4@vger.kernel.org, Lukas Czerner <lczerner@redhat.com>,
Andreas Dilger <adilger.kernel@dilger.ca>
Subject: Re: [PATCH 1/1] ext4: Replace ext4_kvfree_array_rcu() by kvfree_rcu_mightsleep()
Date: Sun, 19 Mar 2023 11:53:40 +0100 [thread overview]
Message-ID: <ZBbptCj8j3gWVesY@pc636> (raw)
In-Reply-To: <28e1585c-7062-49c2-b08e-a5d33ca06577@paulmck-laptop>
On Fri, Mar 17, 2023 at 05:31:04PM -0700, Paul E. McKenney wrote:
> On Fri, Mar 17, 2023 at 08:15:58AM +0100, Uladzislau Rezki (Sony) wrote:
> > The ext4_kvfree_array_rcu() function was introduced in order to
> > release some memory after a grace period during resizing of a
> > partition. An object that is freed does not contain any rcu_head
> > filed.
> >
> > To do so, it requires to allocate some extra memory for a special
> > structure that has an rcu_head filed and pointer one where a freed
> > memory is attached. Finally call_rcu() API is invoked.
> >
> > Since we have a single argument of kvfree_rcu() API, we can easily
> > replace all that tricky code by one single call that does the same
> > but in more efficient way.
> >
> > Cc: linux-ext4@vger.kernel.org
> > Cc: Lukas Czerner <lczerner@redhat.com>
> > Cc: Andreas Dilger <adilger.kernel@dilger.ca>
> > Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
>
> From an RCU perspective:
>
> Reviewed-by: Paul E. McKenney <paulmck@kernel.org>
>
Thank you!
--
Uladzislau Rezki
prev parent reply other threads:[~2023-03-19 10:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 7:15 [PATCH 1/1] ext4: Replace ext4_kvfree_array_rcu() by kvfree_rcu_mightsleep() Uladzislau Rezki (Sony)
2023-03-18 0:31 ` Paul E. McKenney
2023-03-19 10:53 ` Uladzislau Rezki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBbptCj8j3gWVesY@pc636 \
--to=urezki@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=frederic@kernel.org \
--cc=joel@joelfernandes.org \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksiy.avramchenko@sony.com \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).