From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99FE4C7619A for ; Wed, 5 Apr 2023 14:39:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237881AbjDEOjE (ORCPT ); Wed, 5 Apr 2023 10:39:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237398AbjDEOjD (ORCPT ); Wed, 5 Apr 2023 10:39:03 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8F845FE9; Wed, 5 Apr 2023 07:38:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680705525; x=1712241525; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=g4l4SXawpYs9BoQ1e8o+bJafQBoj8zd6EQRUcysjpCg=; b=c11CGsILH0pI4IzX00yH6MTOpo53vPaPT9N/0qZ5Jij9Cl9fprtPwuvi 0JhbZHIfQ30F7N4abDLzffgE9912mRV8lEeY8vGSrsUAfK0rkZfjJr5bU b0t/XIeAdnFB4IKA2WbN+SnH2U+mL9PPa7+WdW2UB/OCHUPcV9r2f5rm5 HHfwDlOq5XwHIfwpiMKL9cBnyLJVilrgFwe6jfg8HaNCWNN+7M2rYmeVN so0sv/F3ed+SYoFO7ENytIY5ABPlnBBCOBXSRBENkQh/J/xc7K4FNkubI 4bqQIoSgz4kAqDGq9p/CJtaqOLeGjDpKtqdLXJyh+YB5whgh881PFvLZd w==; X-IronPort-AV: E=McAfee;i="6600,9927,10671"; a="428754798" X-IronPort-AV: E=Sophos;i="5.98,321,1673942400"; d="scan'208";a="428754798" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Apr 2023 07:38:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10671"; a="680308910" X-IronPort-AV: E=Sophos;i="5.98,321,1673942400"; d="scan'208";a="680308910" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga007.jf.intel.com with ESMTP; 05 Apr 2023 07:38:42 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pk4HY-00Cs5q-1Y; Wed, 05 Apr 2023 17:38:40 +0300 Date: Wed, 5 Apr 2023 17:38:40 +0300 From: Andy Shevchenko To: Greg Kroah-Hartman Cc: Kees Cook , Cezary Rojewski , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, Theodore Ts'o , Jan Kara , "Rafael J. Wysocki" Subject: Re: [PATCH v2 0/3] lib/string_helpers et al.: Change return value of strreplace() Message-ID: References: <20230323123704.37983-1-andriy.shevchenko@linux.intel.com> <2023040523-unworthy-uncured-1eab@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2023040523-unworthy-uncured-1eab@gregkh> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Apr 05, 2023 at 04:24:42PM +0200, Greg Kroah-Hartman wrote: > On Wed, Apr 05, 2023 at 04:34:31PM +0300, Andy Shevchenko wrote: > > On Thu, Mar 23, 2023 at 02:37:01PM +0200, Andy Shevchenko wrote: > > > It's more convenient to have strreplace() to return the pointer to > > > the string itself. This will help users to make their code better. > > > > > > The patch 1 kills the only user of the returned value of strreplace(), > > > Patch 2 converts the return value of strreplace(). And patch 3 shows > > > how it may be useful. That said, the series can be routed via fs tree, > > > with or without the last patch. > > > > Since there are no comments, who can apply this (patches 1 and 2)? > > Greg, are you fine with the kobject change? > > Sure, want me to take them all through my driver-core tree? Fine by me! Dunno about others. Kees? -- With Best Regards, Andy Shevchenko