From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: Ritesh Harjani <ritesh.list@gmail.com>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
"Darrick J . Wong" <djwong@kernel.org>,
Ojaswin Mujoo <ojaswin@linux.ibm.com>,
Disha Goel <disgoel@linux.ibm.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCHv5 2/9] fs/buffer.c: Add generic_buffer_fsync implementation
Date: Mon, 17 Apr 2023 22:04:29 -0700 [thread overview]
Message-ID: <ZD4k3Sp7wDQu4wkU@infradead.org> (raw)
In-Reply-To: <20230417164550.yw6p4ddruutxqqax@quack3>
On Mon, Apr 17, 2023 at 06:45:50PM +0200, Jan Kara wrote:
> Hum, I think the difference sync vs fsync is too subtle and non-obvious.
Agreed.
> I can see sensible pairs like:
>
> __generic_buffers_fsync() - "__" indicates you should know what you
> are doing when calling this
> generic_buffers_fsync()
>
> or
>
> generic_buffers_fsync()
> generic_file_fsync() - difficult at this point as there's name
> clash
>
> or
>
> generic_buffers_fsync_noflush()
> generic_buffers_fsync() - obvious what the default "safe" choice
> is.
>
> or something like that.
I'd prefer the last option as the most explicit one.
next prev parent reply other threads:[~2023-04-18 5:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-16 10:08 [PATCHv5 0/9] ext2: DIO to use iomap Ritesh Harjani (IBM)
2023-04-16 10:08 ` [PATCHv5 1/9] ext2/dax: Fix ext2_setsize when len is page aligned Ritesh Harjani (IBM)
2023-04-16 10:08 ` [PATCHv5 2/9] fs/buffer.c: Add generic_buffer_fsync implementation Ritesh Harjani (IBM)
2023-04-17 11:01 ` Jan Kara
2023-04-17 11:07 ` Jan Kara
2023-04-17 11:38 ` Ritesh Harjani
2023-04-17 16:45 ` Jan Kara
2023-04-18 5:04 ` Christoph Hellwig [this message]
2023-04-20 14:42 ` Ritesh Harjani
2023-04-16 10:08 ` [PATCHv5 3/9] ext4: Use generic_buffer_fsync() implementation Ritesh Harjani (IBM)
2023-04-16 10:08 ` [PATCHv5 4/9] ext2: " Ritesh Harjani (IBM)
2023-04-16 10:08 ` [PATCHv5 5/9] ext2: Move direct-io to use iomap Ritesh Harjani (IBM)
2023-04-17 11:20 ` Jan Kara
2023-04-20 14:48 ` Ritesh Harjani
2023-04-16 10:08 ` [PATCHv5 6/9] fs.h: Add TRACE_IOCB_STRINGS for use in trace points Ritesh Harjani (IBM)
2023-04-16 10:08 ` [PATCHv5 7/9] ext2: Add direct-io " Ritesh Harjani (IBM)
2023-04-16 10:08 ` [PATCHv5 8/9] iomap: Remove IOMAP_DIO_NOSYNC unused dio flag Ritesh Harjani (IBM)
2023-04-16 10:08 ` [PATCHv5 9/9] iomap: Add DIO tracepoints Ritesh Harjani (IBM)
2023-04-16 13:49 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZD4k3Sp7wDQu4wkU@infradead.org \
--to=hch@infradead.org \
--cc=disgoel@linux.ibm.com \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).