From: "Theodore Ts'o" <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org,
Christian Brauner <brauner@kernel.org>,
syzbot+aacb82fca60873422114@syzkaller.appspotmail.com,
syzbot+6b7df7d5506b32467149@syzkaller.appspotmail.com
Subject: Re: [PATCH] ext4: Fix lockdep warning when enabling MMP
Date: Sun, 30 Apr 2023 12:34:00 -0400 [thread overview]
Message-ID: <ZE6YeCaQa01nAWYT@mit.edu> (raw)
In-Reply-To: <20230411121019.21940-1-jack@suse.cz>
On Tue, Apr 11, 2023 at 02:10:19PM +0200, Jan Kara wrote:
> When we enable MMP in ext4_multi_mount_protect() during mount or
> remount, we end up calling sb_start_write() from write_mmp_block(). This
> triggers lockdep warning because freeze protection ranks above s_umount
> semaphore we are holding during mount / remount. The problem is harmless
> because we are guaranteed the filesystem is not frozen during mount /
> remount but still let's fix the warning by not grabbing freeze
> protection from ext4_multi_mount_protect().
>
> Reported-by: syzbot+aacb82fca60873422114@syzkaller.appspotmail.com
I believe this is the wrong Reported-by. The correct one looks like
it should be:
Reported-by: syzbot+6b7df7d5506b32467149@syzkaller.appspotmail.com
Link: https://syzkaller.appspot.com/bug?id=ab7e5b6f400b7778d46f01841422e5718fb81843
It's also helpful to add a Link line to the Syzkaller dashboard to
make it easier to find the relevant Syzbot report.
I'll put this on my todo list to grab for the next batch of ext4
fixups.
- Ted
next prev parent reply other threads:[~2023-04-30 16:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 12:10 [PATCH] ext4: Fix lockdep warning when enabling MMP Jan Kara
2023-04-11 13:52 ` Christian Brauner
2023-04-30 16:34 ` Theodore Ts'o [this message]
2023-04-30 16:44 ` Theodore Ts'o
2023-05-02 9:51 ` Jan Kara
2023-05-13 4:59 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZE6YeCaQa01nAWYT@mit.edu \
--to=tytso@mit.edu \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=syzbot+6b7df7d5506b32467149@syzkaller.appspotmail.com \
--cc=syzbot+aacb82fca60873422114@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox