From: "Theodore Ts'o" <tytso@mit.edu>
To: Nathan Chancellor <nathan@kernel.org>
Cc: adilger.kernel@dilger.ca, yanaijie@huawei.com,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4: Fix unused iterator variable warnings
Date: Fri, 28 Apr 2023 00:00:19 -0400 [thread overview]
Message-ID: <ZEtE059I5rsxntBu@mit.edu> (raw)
In-Reply-To: <20230420-ext4-unused-variables-super-c-v1-1-138b6db6c21c@kernel.org>
On Thu, Apr 20, 2023 at 09:51:24AM -0700, Nathan Chancellor wrote:
>
> The kernel has updated to gnu11, allowing the variables to be declared
> within the for loop. Do so to clear up the warnings.
This is OK for this patch, since it's fixing a patch that landed
during this merge window, and it's unlikely this cause problems with
any future security patches that will need to be backported into 5.15,
5.10, etc. --- or result in patch conflicts that will be any worse
than what we already have.
However, for anything that might be something that needs to be
backported into LTS kernels, or be in code that might get be involved
with a LTS backport patch, let's not use any C11/GNU11 whenever
possible.
- Ted
next prev parent reply other threads:[~2023-04-28 4:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 16:51 [PATCH] ext4: Fix unused iterator variable warnings Nathan Chancellor
2023-04-21 1:52 ` Jason Yan
2023-04-24 16:25 ` Jan Kara
2023-04-27 12:36 ` Geert Uytterhoeven
2023-04-27 18:29 ` Nathan Chancellor
2023-04-28 7:45 ` Geert Uytterhoeven
2023-04-28 4:00 ` Theodore Ts'o [this message]
2023-04-28 5:21 ` Theodore Ts'o
2023-04-30 17:59 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEtE059I5rsxntBu@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=yanaijie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox