From: "Theodore Ts'o" <tytso@mit.edu>
To: Eric Biggers <ebiggers@kernel.org>
Cc: youling 257 <youling257@gmail.com>,
jack@suse.cz, hch@infradead.org, hch@lst.de,
linux-ext4@vger.kernel.org, ritesh.list@gmail.com,
keescook@chromium.org
Subject: Re: [PATCH v4 12/13] ext4: Stop providing .writepage hook
Date: Wed, 10 May 2023 18:00:18 -0400 [thread overview]
Message-ID: <ZFwT8gYip+nPmo0w@mit.edu> (raw)
In-Reply-To: <20230510065036.GD1851@quark.localdomain>
On Tue, May 09, 2023 at 11:50:36PM -0700, Eric Biggers wrote:
> On Wed, May 10, 2023 at 01:47:58PM +0800, youling 257 wrote:
> > I do more test, it is android esdfs or sdcardfs
> > /storage/emulated/0/Android/data problem,
> > "ext4: Stop providing .writepage hook" cause
> > /storage/emulated/0/Android/data/com.android.gallery3d/cache/imgcache.0
> > /storage/emulated/0/Android/data/com.android.gallery3d/cache/imgcache.1
> > /storage/emulated/0/Android/data/com.android.gallery3d/cache/imgcache.idx
> > unable read,
> >
> > on linux 6.4, i use mount bind data/media on storage/emulated, chmod
> > -R 0777 /data/media/0, rm
> > /storage/emulated/0/Android/data/com.android.gallery3d/cache/*, open
> > gallery app can read pictures thumbnail,
> > /storage/emulated/0/Android/data/com.android.gallery3d/cache/imgcache.idx
> > /storage/emulated/0/Android/data/com.android.gallery3d/cache/imgcache.0
> > /storage/emulated/0/Android/data/com.android.gallery3d/cache/imgcache.1
> > available read.
>
> Maybe try reverting your commit that added esdfs to your kernel? It should not
> be needed at all.
Youling, what version of Android are you trying to run with the latest
bleeding edge kernel? Starting with Android 11, sdcardfs was
deprecated[1].
SDCardFS is deprecated on devices that launch with Android 11 or
higher and run kernel version 5.4 or higher. On such devices, VTS
testing doesn't allow mounted file systems listed as
SDCardFS. Devices that launch with Android 11 or higher but run
kernel version 4.19 or lower can continue to use SDCardFS, but
Google doesn't provide additional support.
[1] https://source.android.com/docs/core/storage/sdcardfs-deprecate
With newer versions of Android, use of something like sdcardfs or
esdfs is not necessary. If you are using an older version of Android,
and you insist on use a bleeding edge kernel where the writepage is
getting deprecated, then someone will need to update esdfs or deal
with the changing internal interfaces of the upstream kernel. This is
not the ext4 upstream developer's problem.
Personally, I would recommend that you *not* try to fix esdfs; that's
because stacking file systems like sdcardfs and esdfs are inherently
unreliable. See the section in [1] entitled, "Why deprecate sdcardfs?".
Instead, what I would recommend is upgrading to a newer version of
Android, and then dropping esdfs from your kernel repository.
- Ted
next prev parent reply other threads:[~2023-05-10 22:00 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 11:27 [PATCH v4 0/13] ext4: Stop using ext4_writepage() for writeout of ordered data Jan Kara
2022-12-07 11:27 ` [PATCH v4 01/13] ext4: Handle redirtying in ext4_bio_write_page() Jan Kara
2022-12-07 11:27 ` [PATCH v4 02/13] ext4: Move keep_towrite handling to ext4_bio_write_page() Jan Kara
2022-12-07 11:27 ` [PATCH v4 03/13] ext4: Remove nr_submitted from ext4_bio_write_page() Jan Kara
2022-12-07 11:27 ` [PATCH v4 04/13] ext4: Drop pointless IO submission " Jan Kara
2022-12-07 11:27 ` [PATCH v4 05/13] ext4: Add support for writepages calls that cannot map blocks Jan Kara
2022-12-07 11:27 ` [PATCH v4 06/13] ext4: Provide ext4_do_writepages() Jan Kara
2022-12-07 11:27 ` [PATCH v4 07/13] ext4: Move percpu_rwsem protection into ext4_writepages() Jan Kara
2022-12-07 11:27 ` [PATCH v4 08/13] ext4: Switch to using ext4_do_writepages() for ordered data writeout Jan Kara
2022-12-07 11:27 ` [PATCH v4 09/13] jbd2: Switch jbd2_submit_inode_data() to use fs-provided hook for " Jan Kara
2022-12-08 15:28 ` Ritesh Harjani (IBM)
2022-12-07 11:27 ` [PATCH v4 10/13] ext4: Switch to using write_cache_pages() for data=journal writeout Jan Kara
2022-12-08 15:40 ` Ritesh Harjani (IBM)
2022-12-08 16:33 ` Jan Kara
2022-12-07 11:27 ` [PATCH v4 11/13] mm: Export buffer_migrate_folio_norefs() Jan Kara
2022-12-07 11:59 ` Christoph Hellwig
2022-12-07 11:27 ` [PATCH v4 12/13] ext4: Stop providing .writepage hook Jan Kara
2023-05-08 17:51 ` youling257
2023-05-09 0:25 ` Jan Kara
2023-05-09 5:02 ` Eric Biggers
2023-05-09 18:36 ` Theodore Ts'o
2023-05-10 5:17 ` youling 257
2023-05-10 5:47 ` youling 257
2023-05-10 6:50 ` Eric Biggers
2023-05-10 22:00 ` Theodore Ts'o [this message]
2022-12-07 11:27 ` [PATCH v4 13/13] ext4: Remove ordered data support from ext4_writepage() Jan Kara
2022-12-08 14:23 ` Theodore Ts'o
2022-12-08 15:40 ` Jan Kara
2022-12-08 15:57 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFwT8gYip+nPmo0w@mit.edu \
--to=tytso@mit.edu \
--cc=ebiggers@kernel.org \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=keescook@chromium.org \
--cc=linux-ext4@vger.kernel.org \
--cc=ritesh.list@gmail.com \
--cc=youling257@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).