From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04D0CC7EE24 for ; Mon, 5 Jun 2023 14:06:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229878AbjFEOGv (ORCPT ); Mon, 5 Jun 2023 10:06:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234262AbjFEOGh (ORCPT ); Mon, 5 Jun 2023 10:06:37 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C260F7; Mon, 5 Jun 2023 07:06:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685973993; x=1717509993; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=WRKu/nfyzxlPOPTEZMAva5K8wh48Rxd1u4OmkEAVcRc=; b=Uhxurm7L76ryW9Mqd1S7e0a3Qk6W9q4eGRvFnPT4zi5OBbHiKXZp1uyE ALRsULT7oG37SV5F3jZqDKcIuEBSRrlcrybSPuHfWAHh7zKLU9qy++LiR b2PLRyi9f4Iki73Rh2jqkm7BRwgF66d+SjorEmJQfdj4VsGWBE7M9q5Rx dHKZygv6IMDXlv3GWx2SGyhms/Q1AP/J90ddoxmM/1RpS1ol3oDDtcsf7 QekjdvbHy4NHcaKXp5z5y/s6Q0DjG2BB0lv6N4J7d7455Y/qkxipu1ft8 2FEvh18QMcqcg6EE5kZeC3KKnSA5L5MOaJ7ZnBGjarVr84fk6UqHITuFK g==; X-IronPort-AV: E=McAfee;i="6600,9927,10732"; a="336727073" X-IronPort-AV: E=Sophos;i="6.00,217,1681196400"; d="scan'208";a="336727073" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jun 2023 07:04:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10732"; a="955343562" X-IronPort-AV: E=Sophos;i="6.00,217,1681196400"; d="scan'208";a="955343562" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga006.fm.intel.com with ESMTP; 05 Jun 2023 07:04:45 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1q6Ap9-001OA1-2b; Mon, 05 Jun 2023 17:04:43 +0300 Date: Mon, 5 Jun 2023 17:04:43 +0300 From: Andy Shevchenko To: Kees Cook Cc: Greg Kroah-Hartman , Kees Cook , Cezary Rojewski , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, Theodore Ts'o , Jan Kara , "Rafael J. Wysocki" Subject: Re: [PATCH v2 0/3] lib/string_helpers et al.: Change return value of strreplace() Message-ID: References: <20230323123704.37983-1-andriy.shevchenko@linux.intel.com> <2023040523-unworthy-uncured-1eab@gregkh> <47D8878A-1108-4AC3-BF7F-507F90F6970A@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47D8878A-1108-4AC3-BF7F-507F90F6970A@kernel.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Apr 05, 2023 at 07:58:40PM -0700, Kees Cook wrote: > On April 5, 2023 7:38:40 AM PDT, Andy Shevchenko wrote: > >On Wed, Apr 05, 2023 at 04:24:42PM +0200, Greg Kroah-Hartman wrote: > >> On Wed, Apr 05, 2023 at 04:34:31PM +0300, Andy Shevchenko wrote: > >> > On Thu, Mar 23, 2023 at 02:37:01PM +0200, Andy Shevchenko wrote: > >> > > It's more convenient to have strreplace() to return the pointer to > >> > > the string itself. This will help users to make their code better. > >> > > > >> > > The patch 1 kills the only user of the returned value of strreplace(), > >> > > Patch 2 converts the return value of strreplace(). And patch 3 shows > >> > > how it may be useful. That said, the series can be routed via fs tree, > >> > > with or without the last patch. > >> > > >> > Since there are no comments, who can apply this (patches 1 and 2)? > >> > Greg, are you fine with the kobject change? > >> > >> Sure, want me to take them all through my driver-core tree? > > > >Fine by me! Dunno about others. Kees? > > Yeah, that's cool by me. :) Greg, does this slip through the cracks? -- With Best Regards, Andy Shevchenko