From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/2] xfs: Fix crash in ext4_bdev_mark_dead()
Date: Wed, 21 Jun 2023 07:53:25 -0700 [thread overview]
Message-ID: <ZJMO5Qm3n0Eg8uam@infradead.org> (raw)
In-Reply-To: <20230621144744.1580-2-jack@suse.cz>
On Wed, Jun 21, 2023 at 04:47:43PM +0200, Jan Kara wrote:
> xfs_bdev_mark_dead() passes bdev->bd_holder to ext4_force_shutdown()
> instead of bdev->bd_super leading to crashes. Fix it.
xfs_bdev_mark_dead is only called for the log and RT devices, for which
the mp is passed as holder to blkdev_get_by_path. bd_super won't be
set for those devices, so this patch will introduce a crash and not fix
one.
prev parent reply other threads:[~2023-06-21 14:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 14:47 [PATCH 0/2] fs: Fixup bdev_mark_dead callbacks for ext4 and xfs Jan Kara
2023-06-21 14:47 ` [PATCH 1/2] ext4: Fix crash in ext4_bdev_mark_dead() Jan Kara
2023-06-21 14:52 ` Christoph Hellwig
2023-06-21 16:26 ` Jan Kara
2023-06-21 14:47 ` [PATCH 2/2] xfs: " Jan Kara
2023-06-21 14:53 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJMO5Qm3n0Eg8uam@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox