From: Matthew Wilcox <willy@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Jeremy Bongio <bongiojp@gmail.com>, Ted Tso <tytso@mit.edu>,
"Darrick J . Wong" <djwong@kernel.org>,
Allison Henderson <allison.henderson@oracle.com>,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 0/1] iomap regression for aio dio 4k writes
Date: Thu, 22 Jun 2023 03:55:52 +0100 [thread overview]
Message-ID: <ZJO4OAYhJlXOBXMf@casper.infradead.org> (raw)
In-Reply-To: <ZJOqC7Cfjr5AoW7S@dread.disaster.area>
On Thu, Jun 22, 2023 at 11:55:23AM +1000, Dave Chinner wrote:
> Ok, so having spent a bit more thought on this away from the office
> this morning, I think there is a generic way we can avoid deferring
> completions for pure overwrites.
OK, this is how we can, but should we? The same amount of work
needs to be done, no matter whether we do it in interrupt context or
workqueue context. Doing it in interrupt context has lower latency,
but maybe allows us to batch up the work and so get better bandwidth.
And we can't handle other interrupts while we're handling this one,
so from a whole-system perspective, I think we'd rather do the work in
the workqueue.
Latency is important for reads, but why is it important for writes?
There's such a thing as a dependent read, but writes are usually buffered
and we can wait as long as we like for a write to complete.
next prev parent reply other threads:[~2023-06-22 2:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 17:29 [PATCH 0/1] iomap regression for aio dio 4k writes Jeremy Bongio
2023-06-21 17:29 ` [PATCH 1/1] For DIO writes with no mapped pages for inode, skip deferring completion Jeremy Bongio
2023-06-21 18:55 ` Matthew Wilcox
2023-06-22 0:04 ` Dave Chinner
2023-06-21 23:59 ` [PATCH 0/1] iomap regression for aio dio 4k writes Dave Chinner
2023-06-22 1:55 ` Dave Chinner
2023-06-22 2:55 ` Matthew Wilcox [this message]
2023-06-22 4:08 ` Christoph Hellwig
2023-06-22 4:47 ` Dave Chinner
2023-06-23 2:32 ` Theodore Ts'o
2023-06-23 3:02 ` Dave Chinner
2023-06-22 23:22 ` Allison Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJO4OAYhJlXOBXMf@casper.infradead.org \
--to=willy@infradead.org \
--cc=allison.henderson@oracle.com \
--cc=bongiojp@gmail.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).