From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98D7FEB64DA for ; Mon, 26 Jun 2023 07:56:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229706AbjFZH4L (ORCPT ); Mon, 26 Jun 2023 03:56:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229572AbjFZH4K (ORCPT ); Mon, 26 Jun 2023 03:56:10 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A5551B0; Mon, 26 Jun 2023 00:56:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=M7NmYC/Iylm9myghHwqILim55SAUt9QrM+UZYk0eJlw=; b=koVawv21+4nk5EmTbsanG4scAf ZitGqUvhvb1pqnPUhBu8dq18h3NwC/QTNsIILUylVoEZCpMnZtvi1lb+uVfA1T6WIwkc6Gg1JAz/e mfetdA1UmIoPkuTvY3Pf9m8xgyCC/v1Wtt9grLUvTSVhnFB94EITb2VhmuQIwbACiW2XYQJQvVb44 axh4/1XFEP/blscM5RSV62nkUxG0UkKipGI3oezFI/uZUMVCca7frZ0UEN3AKB6mOXss8OFgFAymn JArOJ92nkFhJIEIkoH6UStLcAan3QGemr4oMhZOaIIK+qxoAdMtOfzingDwxJUwRDQg3srsRb20NF KiJxWXBg==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qDh4m-009bLM-0z; Mon, 26 Jun 2023 07:55:56 +0000 Date: Mon, 26 Jun 2023 00:55:56 -0700 From: Christoph Hellwig To: Bean Huo Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, akpm@linux-foundation.org, jack@suse.cz, jack@suse.com, tytso@mit.edu, adilger.kernel@dilger.ca, mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com, willy@infradead.org, hch@infradead.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com, beanhuo@micron.com Subject: Re: [RESEND PATCH v3 2/2] fs: convert block_commit_write to return void Message-ID: References: <20230626055518.842392-1-beanhuo@iokpp.de> <20230626055518.842392-3-beanhuo@iokpp.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230626055518.842392-3-beanhuo@iokpp.de> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Looks good: Reviewed-by: Christoph Hellwig