From: Matthew Wilcox <willy@infradead.org>
To: Bean Huo <beanhuo@iokpp.de>
Cc: viro@zeniv.linux.org.uk, brauner@kernel.org,
akpm@linux-foundation.org, jack@suse.cz, jack@suse.com,
tytso@mit.edu, adilger.kernel@dilger.ca, mark@fasheh.com,
jlbec@evilplan.org, joseph.qi@linux.alibaba.com,
hch@infradead.org, linux-ext4@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
ocfs2-devel@oss.oracle.com, beanhuo@micron.com
Subject: Re: [RESEND PATCH v3 0/2] clean up block_commit_write
Date: Mon, 26 Jun 2023 13:26:55 +0100 [thread overview]
Message-ID: <ZJmED0CpVewunniH@casper.infradead.org> (raw)
In-Reply-To: <20230626055518.842392-1-beanhuo@iokpp.de>
On Mon, Jun 26, 2023 at 07:55:16AM +0200, Bean Huo wrote:
> change log:
> v1--v2:
> 1. reordered patches
>
> v2--v3:
> 1. rebased patches to git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next
It's be nice to have a bit of an explanation for the whole series here,
but I think the two patches work standalone.
If you'd like to extend this work, you could convert the callers of
block_commit_write() to use a folio instead of a page and then unify
block_commit_write() and __block_commit_write() as you did in the earlier
version of your patchset. It shouldn't be too hard, both callers in
ext4 and the caller in iomap are already done. That just leaves the
three callers in ocfs2 and the one caller in udf.
prev parent reply other threads:[~2023-06-26 12:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-26 5:55 [RESEND PATCH v3 0/2] clean up block_commit_write Bean Huo
2023-06-26 5:55 ` [RESEND PATCH v3 1/2] fs/buffer: " Bean Huo
2023-06-26 7:55 ` Christoph Hellwig
2023-06-26 12:21 ` Matthew Wilcox
2023-06-26 13:41 ` Jan Kara
2023-06-26 5:55 ` [RESEND PATCH v3 2/2] fs: convert block_commit_write to return void Bean Huo
2023-06-26 7:55 ` Christoph Hellwig
2023-06-26 12:21 ` Matthew Wilcox
2023-06-26 12:26 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJmED0CpVewunniH@casper.infradead.org \
--to=willy@infradead.org \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=beanhuo@iokpp.de \
--cc=beanhuo@micron.com \
--cc=brauner@kernel.org \
--cc=hch@infradead.org \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=jlbec@evilplan.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark@fasheh.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).