From: Brian Foster <bfoster@redhat.com>
To: syzbot <syzbot+307da6ca5cb0d01d581a@syzkaller.appspotmail.com>
Cc: linux-ext4@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [ext4?] WARNING in ext4_iomap_begin (2)
Date: Fri, 29 Sep 2023 13:25:08 -0400 [thread overview]
Message-ID: <ZRcIdBOnpNyCQ4qh@bfoster> (raw)
In-Reply-To: <0000000000003a874b06067b1d4d@google.com>
#syz test: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
diff --git a/fs/ext4/file.c b/fs/ext4/file.c
index 6830ea3a6c59..cad659c2e9cc 100644
--- a/fs/ext4/file.c
+++ b/fs/ext4/file.c
@@ -537,6 +537,9 @@ static ssize_t ext4_dio_write_iter(struct kiocb *iocb, struct iov_iter *from)
bool ilock_shared = true;
int dio_flags = 0;
+ if (ext4_test_inode_state(inode, EXT4_STATE_MAY_INLINE_DATA))
+ ilock_shared = false;
+
/*
* Quick check here without any i_rwsem lock to see if it is extending
* IO. A more reliable check is done in ext4_dio_write_checks() with
next prev parent reply other threads:[~2023-09-29 17:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-17 3:29 [syzbot] [ext4?] WARNING in ext4_iomap_begin (2) syzbot
2023-09-29 8:21 ` syzbot
2023-09-29 17:25 ` Brian Foster [this message]
2023-09-29 17:45 ` syzbot
2023-09-29 19:19 ` Brian Foster
2023-09-29 19:40 ` syzbot
2023-09-29 14:29 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRcIdBOnpNyCQ4qh@bfoster \
--to=bfoster@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=syzbot+307da6ca5cb0d01d581a@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).