From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 392234D59E for ; Wed, 1 May 2024 09:40:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714556413; cv=none; b=XTi7hzPDHn8eLKAzCrf5CJCth97ItfFR6dGF+i8MKVjO0UnxU8hOZJ+qOyGGke3+NDoBtFG64Qzd2v9MAeyabNObWTKVqyNAccNHtG87eMQia/KU/YH+UNHuQzYeAp9J579Ixxi5o7jMWFFJSlRYsOMm0dpgewagf+39XyJMSdM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714556413; c=relaxed/simple; bh=8bkvwyzVgHvGpzRRyZA+OUum8mDLE0skINvxj/Xrkcg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kDQiUxiJp6/owVlF3yJYDUHMNTeqJWjMuGrEwwo2ikSAaC4KgO6iJE0UeL6+8KM+4j12dYg3Qmoty2kWlyNovvd+H97aQ1uKPi98z9VrUE+y9lFBl4KUX8mZtWyTVmXIP9WYHU0rtxpu5prGpnZ4YWOIVjJfD1hYlzh3L7lbvQs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fromorbit.com; spf=pass smtp.mailfrom=fromorbit.com; dkim=pass (2048-bit key) header.d=fromorbit-com.20230601.gappssmtp.com header.i=@fromorbit-com.20230601.gappssmtp.com header.b=S6KtYL8k; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fromorbit.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fromorbit.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fromorbit-com.20230601.gappssmtp.com header.i=@fromorbit-com.20230601.gappssmtp.com header.b="S6KtYL8k" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1ec85c2f469so4591915ad.1 for ; Wed, 01 May 2024 02:40:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1714556409; x=1715161209; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wT6FpY3G8icgSQcw7GLJpHBZGPLegu0OyLVBane8oNQ=; b=S6KtYL8kxy+kmbtasi3Jab54ebIxYuwh3m1q3bMtpY7leKLOBORXoPul3ASVc0MJQR JMHKUPA5eVWbEAfSQPcKT6ZzjBbIPrJT4SyDbi8Nj5fb/4MD51Zt9/0M9ryqX0YxTnkF NoyBqM4KFx3oGRp5oN8L6VdC/TBvq/GZmCPa1i1vO37QFwrt1cWsg2yWSR/5h0jKpKtC Cq1G7wHRswtuCNm//BuBQ7zVY+kePC59pyUMTykV0ahcWIblNmv0aIh1oluwGtTSZukB SsMB20VV/7YY8N35q7fvy87aeXXwAACgaIIZF1++IriVRCfabPqekt1Slqhu1U3IdwuA aMBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714556409; x=1715161209; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wT6FpY3G8icgSQcw7GLJpHBZGPLegu0OyLVBane8oNQ=; b=ZpmK8p0yEoui7/RH7556WC6+VEODZwNnb36iMXdNQUvDcqB6y5hzDZdfuVrmEVLZ2K H3gPMQp/KyzDPpD24Q7eQg7V+ZX2rOAiZr4GHef9FG+f4SgJTppVQa4m+WVomBvdyzCs Bn/je96XeuvRXIgVVYUSpThpeVxs+T9xj963pltW+RW9gI3bK8Q6PzmgyclmOrOthX3Y iHPH2xttiL22dQuIWZjp97eKyvx10SVlP+LFdFefs84JHemKVM0NcTSAH9CCde++ewl/ 8vdCcHXJcw8nFzXWDee/YBC4bDRXS6ww+CllMUrIpW3SKUhXFBJkUAVl7wMEE8Ku1kfy CQTw== X-Gm-Message-State: AOJu0Yx6BrTi4zcUfIMXAMCRwpqC7mC7Mpv7eJFCRWB5SzXpU7CMCa7q 7XDaASWKjhOqZrGDGXEZ0ejXlb56PS0Xnx8P6RcxYCr8X0s1yPDK++HznwrIET4= X-Google-Smtp-Source: AGHT+IEaOpqOneqIif2Te/uo4KR9GvWB9QZnymHXhoZDlcycKWWY9JInC0Qe5XsLY7mFCgHMhhrjpg== X-Received: by 2002:a17:90b:605:b0:2a2:fec9:1bbd with SMTP id gb5-20020a17090b060500b002a2fec91bbdmr7291676pjb.17.1714556409282; Wed, 01 May 2024 02:40:09 -0700 (PDT) Received: from dread.disaster.area (pa49-179-32-121.pa.nsw.optusnet.com.au. [49.179.32.121]) by smtp.gmail.com with ESMTPSA id bk8-20020a17090b080800b002a51dcecc49sm968664pjb.38.2024.05.01.02.40.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 02:40:08 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1s26Ra-00HDgc-2Q; Wed, 01 May 2024 19:40:06 +1000 Date: Wed, 1 May 2024 19:40:06 +1000 From: Dave Chinner To: Zhang Yi Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.cz, ritesh.list@gmail.com, hch@infradead.org, djwong@kernel.org, willy@infradead.org, zokeefe@google.com, yi.zhang@huawei.com, chengzhihao1@huawei.com, yukuai3@huawei.com, wangkefeng.wang@huawei.com Subject: Re: [RFC PATCH v4 27/34] ext4: implement zero_range iomap path Message-ID: References: <20240410142948.2817554-1-yi.zhang@huaweicloud.com> <20240410142948.2817554-28-yi.zhang@huaweicloud.com> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240410142948.2817554-28-yi.zhang@huaweicloud.com> On Wed, Apr 10, 2024 at 10:29:41PM +0800, Zhang Yi wrote: > From: Zhang Yi > > Add ext4_iomap_zero_range() for the zero_range iomap path, it zero out > the mapped blocks, all work have been done in iomap_zero_range(), so > call it directly. > > Signed-off-by: Zhang Yi > --- > fs/ext4/inode.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c > index 9d694c780007..5af3b8acf1b9 100644 > --- a/fs/ext4/inode.c > +++ b/fs/ext4/inode.c > @@ -4144,6 +4144,13 @@ static int __ext4_block_zero_page_range(handle_t *handle, > return err; > } > > +static int ext4_iomap_zero_range(struct inode *inode, > + loff_t from, loff_t length) > +{ > + return iomap_zero_range(inode, from, length, NULL, > + &ext4_iomap_buffered_read_ops); > +} Zeroing is a buffered write operation, not a buffered read operation. It runs though iomap_write_begin(), so needs all the stale iomap detection stuff to be set up for correct operation. -Dave. -- Dave Chinner david@fromorbit.com