From: Tejun Heo <tj@kernel.org>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: Haifeng Xu <haifeng.xu@shopee.com>,
viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz,
tytso@mit.edu, yi.zhang@huaweicloud.com,
linux-ext4@vger.kernel.org, linux-block@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
"yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH] buffer: Associate the meta bio with blkg from buffer page
Date: Fri, 30 Aug 2024 22:03:30 -1000 [thread overview]
Message-ID: <ZtLOUuoxnobhYgrm@slm.duckdns.org> (raw)
In-Reply-To: <9cae20f9-aa6a-77da-8978-b4cfb7b0cb73@huaweicloud.com>
Hello,
On Sat, Aug 31, 2024 at 02:11:08PM +0800, Yu Kuai wrote:
...
> > I think the right way to do it is marking the bio with REQ_META and
> > implement forced charging in blk-throtl similar to blk-iocost.
>
> This is the exact thing I did in the code I attached in the other
> thread, do you take a look?
>
> https://lore.kernel.org/all/97fc38e6-a226-5e22-efc2-4405beb6d75b@huaweicloud.com/
Sorry about missing it but yeah that *looks* like the right direction to be
headed. Would you mind testing it and turning it into a proper patch?
Thanks.
--
tejun
next prev parent reply other threads:[~2024-08-31 8:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 3:32 [PATCH] buffer: Associate the meta bio with blkg from buffer page Haifeng Xu
2024-08-28 5:19 ` Christoph Hellwig
2024-08-29 16:20 ` kernel test robot
2024-08-29 17:43 ` kernel test robot
2024-08-30 19:37 ` Tejun Heo
2024-08-31 6:11 ` Yu Kuai
2024-08-31 8:03 ` Tejun Heo [this message]
2024-08-31 9:48 ` Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZtLOUuoxnobhYgrm@slm.duckdns.org \
--to=tj@kernel.org \
--cc=brauner@kernel.org \
--cc=haifeng.xu@shopee.com \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=yi.zhang@huaweicloud.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox