From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93F43C433E2 for ; Fri, 19 Jun 2020 12:05:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 74CAF207FC for ; Fri, 19 Jun 2020 12:05:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dJsFVGJE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731731AbgFSMFD (ORCPT ); Fri, 19 Jun 2020 08:05:03 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:43400 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731776AbgFSMFA (ORCPT ); Fri, 19 Jun 2020 08:05:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592568299; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=orSSRgFfv3qUT+UsrD9xGOSEY9WAuTcx2l/m7DY5Xdw=; b=dJsFVGJERgbIziFvz9HM62WJcXFZ49SkCswYLaPtRQ3xwT9iDd8zWCcRzQ1vqkN/IbcUUM y18/bqLhaI1PedACcT8FdRt5OzSL1mynA0cguJQaPEZQhdmZxk41jK/2UCz6Zr286bdoJa A7gC3HcfQJuVk8Q26kplnyS+NKs/mkA= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-184-qTpH6XI9MQCqPSOzsnO1QQ-1; Fri, 19 Jun 2020 08:04:55 -0400 X-MC-Unique: qTpH6XI9MQCqPSOzsnO1QQ-1 Received: by mail-qk1-f198.google.com with SMTP id u186so416667qka.4 for ; Fri, 19 Jun 2020 05:04:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=orSSRgFfv3qUT+UsrD9xGOSEY9WAuTcx2l/m7DY5Xdw=; b=RVdg7QXFp0vBsIEVNcj1nMD7GGwjbUjZlIqU+DmATHZunDyVr1RC5Plbgh7e1vJewF 8qHClBC7qUxIVNSa1WoO3lg0o38P2KqWIWGiO7Nevf4lzYcBFMryp2KWcv9iQOS4PJK7 MOexs0BZNsbCS22oVtc3oz8fMZOA+wR0dIovHOS7ZeDWk4G1crReTzFTMe2xKc+TwsEq +jS1Yn47ZDgYtJKdZ82wuyRWvA9egvzHMZzAykMkmeww05/wM5TNcEvvWSr7Rw4DxEME 9u8+zw7kH7sOuOUwANr7HZ0g/D/0koAKsJnTgl0wOcuk8Hz0EQXm7w4idD87XeanCV7p 8z/g== X-Gm-Message-State: AOAM531C2kiRT1AA4BXabCOph8xyTx+fn6wbWdIYtBEGVyn/YgL57vvr sczMOoDZMz5QlyUPNlh3AGnqv0EuLe7kF6U1netVgNYV8wK8bnqQ7R2MfOkcwaghovBQi788ocm xXxtgKWSj3AKqOcYfFyiaCg== X-Received: by 2002:aed:3b33:: with SMTP id p48mr2950294qte.205.1592568295108; Fri, 19 Jun 2020 05:04:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx75r1dWTHaMyeSP1ld6gxk57RCqWkHZnNjQIqc+NyYiE+3KD94I/f13g1qhV9uGflJRhIWuw== X-Received: by 2002:aed:3b33:: with SMTP id p48mr2950256qte.205.1592568294693; Fri, 19 Jun 2020 05:04:54 -0700 (PDT) Received: from tleilax.poochiereds.net (68-20-15-154.lightspeed.rlghnc.sbcglobal.net. [68.20.15.154]) by smtp.gmail.com with ESMTPSA id s15sm6751128qtc.95.2020.06.19.05.04.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jun 2020 05:04:53 -0700 (PDT) Message-ID: Subject: Re: [PATCH] fs: i_version mntopt gets visible through /proc/mounts From: Jeff Layton To: Dave Chinner , "J. Bruce Fields" Cc: Masayoshi Mizuma , Eric Sandeen , "Darrick J. Wong" , Christoph Hellwig , Theodore Ts'o , Andreas Dilger , Alexander Viro , Masayoshi Mizuma , linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs Date: Fri, 19 Jun 2020 08:04:53 -0400 In-Reply-To: <20200619024455.GN2005@dread.disaster.area> References: <20200617172456.GP11245@magnolia> <8f0df756-4f71-9d96-7a52-45bf51482556@sandeen.net> <20200617181816.GA18315@fieldses.org> <4cbb5cbe-feb4-2166-0634-29041a41a8dc@sandeen.net> <20200617184507.GB18315@fieldses.org> <20200618013026.ewnhvf64nb62k2yx@gabell> <20200618030539.GH2005@dread.disaster.area> <20200618034535.h5ho7pd4eilpbj3f@gabell> <20200618223948.GI2005@dread.disaster.area> <20200619022005.GA25414@fieldses.org> <20200619024455.GN2005@dread.disaster.area> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.3 (3.36.3-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Fri, 2020-06-19 at 12:44 +1000, Dave Chinner wrote: > On Thu, Jun 18, 2020 at 10:20:05PM -0400, J. Bruce Fields wrote: > > On Fri, Jun 19, 2020 at 08:39:48AM +1000, Dave Chinner wrote: > > > On Wed, Jun 17, 2020 at 11:45:35PM -0400, Masayoshi Mizuma wrote: > > > > Thank you for pointed it out. > > > > How about following change? I believe it works both xfs and btrfs... > > > > > > > > diff --git a/fs/super.c b/fs/super.c > > > > index b0a511bef4a0..42fc6334d384 100644 > > > > --- a/fs/super.c > > > > +++ b/fs/super.c > > > > @@ -973,6 +973,9 @@ int reconfigure_super(struct fs_context *fc) > > > > } > > > > } > > > > > > > > + if (sb->s_flags & SB_I_VERSION) > > > > + fc->sb_flags |= MS_I_VERSION; > > > > + > > > > WRITE_ONCE(sb->s_flags, ((sb->s_flags & ~fc->sb_flags_mask) | > > > > (fc->sb_flags & fc->sb_flags_mask))); > > > > /* Needs to be ordered wrt mnt_is_readonly() */ > > > > > > This will prevent SB_I_VERSION from being turned off at all. That > > > will break existing filesystems that allow SB_I_VERSION to be turned > > > off on remount, such as ext4. > > > > > > The manipulations here need to be in the filesystem specific code; > > > we screwed this one up so badly there is no "one size fits all" > > > behaviour that we can implement in the generic code... > > > > My memory was that after Jeff Layton's i_version patches, there wasn't > > really a significant performance hit any more, so the ability to turn it > > off is no longer useful. > > Yes, I completely agree with you here. However, with some > filesystems allowing it to be turned off, we can't just wave our > hands and force enable the option. Those filesystems - if the > maintainers chose to always enable iversion - will have to go > through a mount option deprecation period before permanently > enabling it. > > > But looking back through Jeff's postings, I don't see him claiming that; > > e.g. in: > > > > https://lore.kernel.org/lkml/20171222120556.7435-1-jlayton@kernel.org/ > > https://lore.kernel.org/linux-nfs/20180109141059.25929-1-jlayton@kernel.org/ > > https://lore.kernel.org/linux-nfs/1517228795.5965.24.camel@redhat.com/ > > > > he reports comparing old iversion behavior to new iversion behavior, but > > not new iversion behavior to new noiversion behavior. > > Yeah, it's had to compare noiversion behaviour on filesystems where > it was understood that it couldn't actually be turned off. And, > realistically, the comaprison to noiversion wasn't really relevant > to the problem Jeff's patchset was addressing... > I actually did do some comparison with that patchset vs. noiversion mounted ext4, and found that there was a small performance delta. It wasn't much but it was measurable enough that I didn't want to propose removing the option from ext4 altogether at the time. It may be worth it to do that now though. -- Jeff Layton