From: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
To: Naresh Kamboju <naresh.kamboju@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-ext4 <linux-ext4@vger.kernel.org>,
clang-built-linux <llvm@lists.linux.dev>
Cc: stable@vger.kernel.org, patches@lists.linux.dev,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
akpm@linux-foundation.org, linux@roeck-us.net, shuah@kernel.org,
patches@kernelci.org, lkft-triage@lists.linaro.org,
pavel@denx.de, jonathanh@nvidia.com, f.fainelli@gmail.com,
sudipm.mukherjee@gmail.com, srw@sladewatkins.net, rwarsow@gmx.de,
conor@kernel.org, Theodore Ts'o <tytso@mit.edu>,
Chao Yu <chao@kernel.org>, Darren Kenny <darren.kenny@oracle.com>,
Vegard Nossum <vegard.nossum@oracle.com>
Subject: Re: [PATCH 5.4 000/313] 5.4.251-rc1 review
Date: Tue, 25 Jul 2023 20:48:03 +0530 [thread overview]
Message-ID: <a3849202-24f9-4ad0-f10c-a4a6f8627e80@oracle.com> (raw)
In-Reply-To: <CA+G9fYuH-jyxJwgEgX4J4+eh=nEEk9aqt4YPNUW9j==mwtw=jA@mail.gmail.com>
Hi Greg,
On 25/07/23 8:16 pm, Naresh Kamboju wrote:
> On Tue, 25 Jul 2023 at 17:06, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
>>
>> This is the start of the stable review cycle for the 5.4.251 release.
>> There are 313 patches in this series, all will be posted as a response
>> to this one. If anyone has any issues with these being applied, please
>> let me know.
>>
>> Responses should be made by Thu, 27 Jul 2023 10:44:26 +0000.
>> Anything received after that time might be too late.
>>
>> The whole patch series can be found in one patch at:
>> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.251-rc1.gz
>> or in the git tree and branch at:
>> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
>> and the diffstat can be found below.
>>
>> thanks,
>>
>> greg k-h
>
> Following commit caused build failures on stable-rc 5.4 and 5.10.
>
> ext4: fix to check return value of freeze_bdev() in ext4_shutdown()
> commit c4d13222afd8a64bf11bc7ec68645496ee8b54b9 upstream.
>
> fs/ext4/ioctl.c:595:7: error: incompatible pointer to integer
> conversion assigning to 'int' from 'struct super_block *'
> [-Wint-conversion]
> ret = freeze_bdev(sb->s_bdev);
> ^ ~~~~~~~~~~~~~~~~~~~~~~~
> 1 error generated.
>
I have seen this error too in 5.4.y build.
Just more information about this.
In 5.4.y:
struct super_block *freeze_bdev(struct block_device *bdev)
{
...
}
In 5.15.y
int freeze_bdev(struct block_device *bdev)
{
...
}
This changed in this commit which is in 5.11-rc1,(not in 5.4.y and 5.10.y)
Commit info:
commit-id : 040f04bd2e825f1d80b14a0e0ac3d830339eb779
subject : fs: simplify freeze_bdev/thaw_bdev
Thanks,
Harshit
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
>
> --
> Linaro LKFT
> https://lkft.linaro.org
next prev parent reply other threads:[~2023-07-25 15:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230725104521.167250627@linuxfoundation.org>
2023-07-25 14:46 ` [PATCH 5.4 000/313] 5.4.251-rc1 review Naresh Kamboju
2023-07-25 15:18 ` Harshit Mogalapalli [this message]
2023-07-26 4:48 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3849202-24f9-4ad0-f10c-a4a6f8627e80@oracle.com \
--to=harshit.m.mogalapalli@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=chao@kernel.org \
--cc=conor@kernel.org \
--cc=darren.kenny@oracle.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lkft-triage@lists.linaro.org \
--cc=llvm@lists.linux.dev \
--cc=naresh.kamboju@linaro.org \
--cc=patches@kernelci.org \
--cc=patches@lists.linux.dev \
--cc=pavel@denx.de \
--cc=rwarsow@gmx.de \
--cc=shuah@kernel.org \
--cc=srw@sladewatkins.net \
--cc=stable@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=vegard.nossum@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).