From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1D38C34056 for ; Wed, 19 Feb 2020 20:24:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9B13424654 for ; Wed, 19 Feb 2020 20:24:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="PoUTRdSy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726750AbgBSUY2 (ORCPT ); Wed, 19 Feb 2020 15:24:28 -0500 Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:3914 "EHLO hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726645AbgBSUY2 (ORCPT ); Wed, 19 Feb 2020 15:24:28 -0500 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Wed, 19 Feb 2020 12:23:16 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Wed, 19 Feb 2020 12:24:27 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Wed, 19 Feb 2020 12:24:27 -0800 Received: from [10.110.48.28] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 19 Feb 2020 20:24:27 +0000 Subject: Re: [PATCH v6 07/19] mm: Put readahead pages in cache earlier To: Matthew Wilcox , Christoph Hellwig CC: , , , , , , , , , References: <20200217184613.19668-1-willy@infradead.org> <20200217184613.19668-12-willy@infradead.org> <20200219144117.GP24185@bombadil.infradead.org> <20200219145246.GA29869@infradead.org> <20200219150103.GQ24185@bombadil.infradead.org> From: John Hubbard X-Nvconfidentiality: public Message-ID: Date: Wed, 19 Feb 2020 12:24:26 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200219150103.GQ24185@bombadil.infradead.org> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1582143796; bh=Stnn+zSSGNCFbZ988J4GuiCkm17Qbq44jVcYhuJTWJc=; h=X-PGP-Universal:Subject:To:CC:References:From:X-Nvconfidentiality: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=PoUTRdSyZJ3hX2dxzQISosJ/wVYoveMKl+7atg1sDrOWdAAaYMtdVxq7QyYHhh7xe EvTmBI7/rq4HLGscXS8LPXNBnQ1Jix4flhNHGsxk201kSI8sMpgUmQGRpk7I9BpUhS +KjQiwXIyu9koQoSyGAly8ElawI2qpwAoJWQDFM4pVRo/Z9yKmG/dGB+jg0mlia4Y2 aAY4dZzfwP+DRcHOuBWJl3IdIgHWxdpwgzTmZEfGVW+WOZbqKq5bU129bePvvI5bU1 dYKswZNLebiNLPAg01grHG4u36LomMBF2QsjP/hPLPNASaXyUhQMXbUJhq2V3Ktwp6 cwNUY5UNidflg== Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On 2/19/20 7:01 AM, Matthew Wilcox wrote: > On Wed, Feb 19, 2020 at 06:52:46AM -0800, Christoph Hellwig wrote: >> On Wed, Feb 19, 2020 at 06:41:17AM -0800, Matthew Wilcox wrote: >>> #define readahead_for_each(rac, page) \ >>> while ((page = readahead_page(rac))) >>> >>> No more readahead_next() to forget to add to filesystems which don't use >>> the readahead_for_each() iterator. Ahem. Yes, this looks very clean. And less error-prone, which I definitely appreciate too. :) >> >> And then kill readahead_for_each and open code the above to make it >> even more obvious? > > Makes sense. > Great! thanks, -- John Hubbard NVIDIA