public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: "Nirjhar Roy (IBM)" <nirjhar.roy.lists@gmail.com>
To: fstests@vger.kernel.org
Cc: linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
	ritesh.list@gmail.com, ojaswin@linux.ibm.com, djwong@kernel.org,
	zlang@kernel.org, david@fromorbit.com,
	nirjhar.roy.lists@gmail.com
Subject: [PATCH v4 3/6] check: Remove redundant _test_mount in check
Date: Wed,  9 Apr 2025 07:00:49 +0000	[thread overview]
Message-ID: <a9c490ad00b6a441ec991306b22c2fd9d6565de3.1744181682.git.nirjhar.roy.lists@gmail.com> (raw)
In-Reply-To: <cover.1744181682.git.nirjhar.roy.lists@gmail.com>

init_rc already does a _test_mount. Hence removing the additional
_test_mount call when OLD_TEST_FS_MOUNT_OPTS != TEST_FS_MOUNT_OPTS.

Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@gmail.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
---
 check | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/check b/check
index 32890470..3d621210 100755
--- a/check
+++ b/check
@@ -791,13 +791,9 @@ function run_section()
 		. common/rc
 		_prepare_test_list
 	elif [ "$OLD_TEST_FS_MOUNT_OPTS" != "$TEST_FS_MOUNT_OPTS" ]; then
+		# Unmount TEST_DEV to apply the updated mount options.
+		# It will be mounted again by init_rc(), called shortly after.
 		_test_unmount 2> /dev/null
-		if ! _test_mount
-		then
-			echo "check: failed to mount $TEST_DEV on $TEST_DIR"
-			status=1
-			exit
-		fi
 	fi
 
 	init_rc
-- 
2.34.1


  parent reply	other threads:[~2025-04-09  7:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-09  7:00 [PATCH v4 0/6] Minor cleanups in common/ Nirjhar Roy (IBM)
2025-04-09  7:00 ` [PATCH v4 1/6] generic/749: Remove redundant sourcing of common/rc Nirjhar Roy (IBM)
2025-04-09  7:00 ` [PATCH v4 2/6] generic/367: Remove redundant sourcing of common/config Nirjhar Roy (IBM)
2025-04-09 15:21   ` Darrick J. Wong
2025-04-09  7:00 ` Nirjhar Roy (IBM) [this message]
2025-04-09 15:21   ` [PATCH v4 3/6] check: Remove redundant _test_mount in check Darrick J. Wong
2025-04-09  7:00 ` [PATCH v4 4/6] check,common{rc,preamble}: Decouple init_rc() call from sourcing common/rc Nirjhar Roy (IBM)
2025-04-09 15:22   ` Darrick J. Wong
2025-04-09  7:00 ` [PATCH v4 5/6] common/config: Introduce _exit wrapper around exit command Nirjhar Roy (IBM)
2025-04-09 15:23   ` Darrick J. Wong
2025-04-09  7:00 ` [PATCH v4 6/6] common: exit --> _exit Nirjhar Roy (IBM)
2025-04-09 15:24   ` Darrick J. Wong
2025-04-09 16:29     ` Nirjhar Roy (IBM)
2025-04-10 14:31     ` Zorro Lang
2025-04-10 16:29       ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a9c490ad00b6a441ec991306b22c2fd9d6565de3.1744181682.git.nirjhar.roy.lists@gmail.com \
    --to=nirjhar.roy.lists@gmail.com \
    --cc=david@fromorbit.com \
    --cc=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=ojaswin@linux.ibm.com \
    --cc=ritesh.list@gmail.com \
    --cc=zlang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox