From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5ADEB2DECB1 for ; Tue, 14 Oct 2025 20:45:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760474757; cv=none; b=m7+pHEXYop6vwZHpz8ef0/1tYgokzFslXkkiiH3NaRVWHlCdrWzbnUl6cmPJitbCPG7DQuxx53SayixmZL0NWaLhwE0G97KS6atKddu+F6zmkyiVlwsyiqoQwVQnuHRN1Yt2teFlZP5sgMXC86TfnPQoF3gdGeE8fd3eCPn7/AY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760474757; c=relaxed/simple; bh=mLMiOvkuQ1waPsYJBAJdPUyickusJQ8ORxj4y3Zep3Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WXOlfqqDmV/suyCenDJyCGmPBJO0OSH0aB/U2UaxbEzHD9OvEQ/ECj0ATi7yc6Vg0Cc/6XpZaw9Bk560NZuIpLOLv/wtZ664C1ricgt6IZPKpf4HGXdQe1clwLoD9WjlIu2AhHIi+TiNitiOKLMOVRB4xxhlHIEWH5sPfnUjik4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fromorbit.com; spf=pass smtp.mailfrom=fromorbit.com; dkim=pass (2048-bit key) header.d=fromorbit-com.20230601.gappssmtp.com header.i=@fromorbit-com.20230601.gappssmtp.com header.b=D74hUHsV; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fromorbit.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fromorbit.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fromorbit-com.20230601.gappssmtp.com header.i=@fromorbit-com.20230601.gappssmtp.com header.b="D74hUHsV" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-33082aed31dso6064732a91.3 for ; Tue, 14 Oct 2025 13:45:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1760474754; x=1761079554; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ProMLWdJiYhd+ReUg4Q/nfu5OGup3NKBCnvPEIlS8hk=; b=D74hUHsVIAuXAszKT9OyaSP01aDFJeS4dtESAdmyVJsGXoAAl6SoLYFzgqG8sO3LVj 6ERxo1FSU1Y3JKmYIIaOBI7kPi3x4Gpy/qkXd2rlwvWCRrTYb1eyGj+5O2baZ6fukQik Gb4qo2yhiBLvajFZ1uKdHX00YcoaXpBLLYt1ZH+9jgc4mxK3LSaG3HibkB4KlKCev0e7 3Xiuj63FONPcDeoK99vIV5AkSYSkhgQq6jbXRMFs8xps1Rd79gaHNdZeCeH0pQZyYIlX 43GH4VKUCNcsCnnFnPE93PllXNK2XvANDk2T9wezW0mBUN0nkZ9WgYK8q0nQIF3CpbgA CMfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760474754; x=1761079554; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ProMLWdJiYhd+ReUg4Q/nfu5OGup3NKBCnvPEIlS8hk=; b=VNwcxoW+H/Z7/TDLod5JvO4fsQqpmuG+5Wtp3EYMY+dqimxBhlhozqA7+q4yyWnABq 6SdgIFD548zXQZ3F5qdoc6ehI0fH/TauPu1D1xcICVx38cOd3xfs2ZMt9Igp7B9u2M55 ApDQueBO6JfRLb2TdQko27ytIRsvULxa5+1HuPUbxF7WpRsF392nx1CZqQZGzXuL9umV eVW7toaA7KY2yuWYpWiUsuGelPcn9QPs3xgq2fDTScrPJxlr6gD6q0mqFk4YRpksLO9P wl7eWoRFE4LFAftgMgYLXvUiO97vMolTThB5Gu4Yemb+YqC46bBvflKW+ekDbNfjTw7p So6Q== X-Forwarded-Encrypted: i=1; AJvYcCWvM5xdIhL4GxTRMMcgSseLuq5afC569hzJtXhW7aLpPRd38ZoLh5lg8xzvbR648TLVZdzPm7qiBett@vger.kernel.org X-Gm-Message-State: AOJu0Yzjj4H8WnWHqtkbAIU2n90VaYrBJFwmvpgrc9361qgvrf2tj/Af UyuFt9tMoNqbPPHlofxmhEKgUOkkFDCoVe45r5946gC3ms1j7Wco600mod+7EF5xDKY= X-Gm-Gg: ASbGncszwDesbMzmooAZgWBdur2Q8hIQrpAFZUsl6PQ7XUZItcPr2VSiWl8usqJ57FT V/U9JFPwxa2saAdhV1x9uo/LxgTLg1t8qiCkDjg8MUEk6cAzY2flr9eTKJmh6hSHN3F13wl9c+k bSuEgOuIIVEK5pvPsEUyYt+6LeK5XKzytxx8YyYOuhzfAEUwFF/oxFU54tJJUjWC8kBvsL/RVRq 2DPQUM+dSc3bVAlhGMporfVu3fetlTpHSooqRpdCmlJRxROPCqlP0PFDeYuionxtacxXHRejsjL 1YMf1bCkK1bJc/bZ2tv4AEaNyYoL5TFF/CSNkHgROY5KlOPQQz8VYGhi1KZX+q67ZZCY3nOchW3 7GBBc0GLQ1zXU+sSjWoSP1aZSXtpQLOa7lHoyNHMo+hyZ4J3t0sO7Sx1rPMM15NsfciE/Ug6KRX wGNAVOWoHJQBltTN+u X-Google-Smtp-Source: AGHT+IEha/464YLIDe1S05FMmmIwJiiHJqNozxP/E/7ahWiUSHSloNCgr/S9uHudRNKH/rfSTuG4WQ== X-Received: by 2002:a17:90b:3947:b0:31e:c95a:cef8 with SMTP id 98e67ed59e1d1-33b5139a259mr32044929a91.32.1760474754350; Tue, 14 Oct 2025 13:45:54 -0700 (PDT) Received: from dread.disaster.area (pa49-180-91-142.pa.nsw.optusnet.com.au. [49.180.91.142]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-33b62631266sm16839994a91.3.2025.10.14.13.45.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Oct 2025 13:45:53 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.98.2) (envelope-from ) id 1v8lu3-0000000Es6g-0Y5G; Wed, 15 Oct 2025 07:45:51 +1100 Date: Wed, 15 Oct 2025 07:45:51 +1100 From: Dave Chinner To: Jan Kara Cc: Christoph Hellwig , Damien Le Moal , "Matthew Wilcox (Oracle)" , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , Chris Mason , David Sterba , Mark Fasheh , Joel Becker , Joseph Qi , Alexander Viro , Christian Brauner , Josef Bacik , linux-block@vger.kernel.org, v9fs@lists.linux.dev, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, jfs-discussion@lists.sourceforge.net, ocfs2-devel@lists.linux.dev, linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 06/10] mm,btrfs: add a filemap_fdatawrite_kick_nr helper Message-ID: References: <20251013025808.4111128-1-hch@lst.de> <20251013025808.4111128-7-hch@lst.de> <74593bac-929b-4496-80e0-43d0f54d6b4c@kernel.org> <4bcpiwrhbrraau7nlp6mxbffprtnlv3piqyn7xkm7j2txxqlmn@3knyilc526ts> <20251014044723.GA30978@lst.de> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Oct 14, 2025 at 11:33:26AM +0200, Jan Kara wrote: > On Tue 14-10-25 06:47:23, Christoph Hellwig wrote: > > On Mon, Oct 13, 2025 at 01:58:15PM +0200, Jan Kara wrote: > > > I don't love filemap_fdatawrite_kick_nr() either. Your > > > filemap_fdatawrite_nrpages() is better but so far we had the distinction > > > that filemap_fdatawrite* is for data integrity writeback and filemap_flush > > > is for memory cleaning writeback. And in some places this is important > > > distinction which I'd like to keep obvious in the naming. So I'd prefer > > > something like filemap_flush_nrpages() (to stay consistent with previous > > > naming) or if Christoph doesn't like flush (as that's kind of overloaded > > > word) we could have filemap_writeback_nrpages(). > > > > Not a big fan of flush, but the important point in this series is > > to have consistent naming. > > I fully agree on that. *nod* > > If we don't like the kick naming we should standardize on _flush (or > > whatever) and have the _range and _nrpages variants of whatever we pick > > for the base name. > > > > Anyone with strong feelings and or good ideas about naming please speak > > up now. > > I agree with either keeping filemap_flush* or using filemap_writeback* (and > renaming filemap_flush to filemap_writeback). I'd prefer filemap_flush* because most people are already familiar with that naming and the expected semnatics. But I could live with filemap_writebacki*, too. Both are better than "kick", IMO. -Dave. -- Dave Chinner david@fromorbit.com