public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
* ext4/004 hangs with -o inlinecrypt,test_dummy_encryption
@ 2025-12-08  6:59 Christoph Hellwig
  2025-12-09  8:40 ` Julian Sun
  0 siblings, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2025-12-08  6:59 UTC (permalink / raw)
  To: linux-ext4

Hi all,

I've just been wanting to test my changes to the inline encruption
fallback code, and it seems like ext/004 (the only ext4 dump test)
hangs when using the following options:

export MKFS_OPTIONS='-O encrypt'
export MOUNT_OPTIONS="-o inlinecrypt,test_dummy_encryption"

I thought I did not see this before, but it reproduces back to at least
Linux 6.17.  This is in an uptodate Debian trixie VM.  The dump/restore
process look like in weird states:

   4727 ttyS0    T      0:00 /usr/sbin/dump -0 -f - /mnt/scratch/dump_restore_dir
   4728 ttyS0    T      0:00 /usr/sbin/restore -urvf -
   4729 ttyS0    T      0:00 /usr/sbin/dump -0 -f - /mnt/scratch/dump_restore_dir
   4730 ttyS0    T      0:00 /usr/sbin/dump -0 -f - /mnt/scratch/dump_restore_dir
   4731 ttyS0    T      0:00 /usr/sbin/dump -0 -f - /mnt/scratch/dump_restore_dir
   4732 ttyS0    T      0:00 /usr/sbin/dump -0 -f - /mnt/scratch/dump_restore_dir


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: ext4/004 hangs with -o inlinecrypt,test_dummy_encryption
  2025-12-08  6:59 ext4/004 hangs with -o inlinecrypt,test_dummy_encryption Christoph Hellwig
@ 2025-12-09  8:40 ` Julian Sun
  2025-12-09  9:46   ` Julian Sun
  0 siblings, 1 reply; 4+ messages in thread
From: Julian Sun @ 2025-12-09  8:40 UTC (permalink / raw)
  To: Christoph Hellwig, linux-ext4

On 12/8/25 2:59 PM, Christoph Hellwig wrote:
> Hi all,
> 
> I've just been wanting to test my changes to the inline encruption
> fallback code, and it seems like ext/004 (the only ext4 dump test)
> hangs when using the following options:
> 
> export MKFS_OPTIONS='-O encrypt'
> export MOUNT_OPTIONS="-o inlinecrypt,test_dummy_encryption"
> 
> I thought I did not see this before, but it reproduces back to at least
> Linux 6.17.  This is in an uptodate Debian trixie VM.  The dump/restore
> process look like in weird states:
> 
>     4727 ttyS0    T      0:00 /usr/sbin/dump -0 -f - /mnt/scratch/dump_restore_dir
>     4728 ttyS0    T      0:00 /usr/sbin/restore -urvf -
>     4729 ttyS0    T      0:00 /usr/sbin/dump -0 -f - /mnt/scratch/dump_restore_dir
>     4730 ttyS0    T      0:00 /usr/sbin/dump -0 -f - /mnt/scratch/dump_restore_dir
>     4731 ttyS0    T      0:00 /usr/sbin/dump -0 -f - /mnt/scratch/dump_restore_dir
>     4732 ttyS0    T      0:00 /usr/sbin/dump -0 -f - /mnt/scratch/dump_restore_dir
> 

I can reproduce this issue locally with both v6.18 and v6.0. The problem 
disappears after removing test_dummy_encryption, and it still reproduces 
when test_dummy_encryption is set alone in MOUNT_OPTIONS. Therefore, I 
believe the issue lies in test_dummy_encryption — it is an 
implementation of fscrypt.

CC: linux-fscrypt

Thanks,
-- 
Julian Sun <sunjunchao@bytedance.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: ext4/004 hangs with -o inlinecrypt,test_dummy_encryption
  2025-12-09  8:40 ` Julian Sun
@ 2025-12-09  9:46   ` Julian Sun
  2025-12-09 21:40     ` Eric Biggers
  0 siblings, 1 reply; 4+ messages in thread
From: Julian Sun @ 2025-12-09  9:46 UTC (permalink / raw)
  To: Christoph Hellwig, linux-ext4; +Cc: linux-fscrypt

On 12/9/25 4:40 PM, Julian Sun wrote:
> 
> I can reproduce this issue locally with both v6.18 and v6.0. The problem 
> disappears after removing test_dummy_encryption, and it still reproduces 
> when test_dummy_encryption is set alone in MOUNT_OPTIONS. Therefore, I 
> believe the issue lies in test_dummy_encryption — it is an 
> implementation of fscrypt.
> 
> CC: linux-fscrypt
> 
> Thanks,

cc linux-fscrypt

-- 
Julian Sun <sunjunchao@bytedance.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: ext4/004 hangs with -o inlinecrypt,test_dummy_encryption
  2025-12-09  9:46   ` Julian Sun
@ 2025-12-09 21:40     ` Eric Biggers
  0 siblings, 0 replies; 4+ messages in thread
From: Eric Biggers @ 2025-12-09 21:40 UTC (permalink / raw)
  To: Julian Sun; +Cc: Christoph Hellwig, linux-ext4, linux-fscrypt, fstests

On Tue, Dec 09, 2025 at 05:46:22PM +0800, Julian Sun wrote:
> On 12/9/25 4:40 PM, Julian Sun wrote:
> > 
> > I can reproduce this issue locally with both v6.18 and v6.0. The problem
> > disappears after removing test_dummy_encryption, and it still reproduces
> > when test_dummy_encryption is set alone in MOUNT_OPTIONS. Therefore, I
> > believe the issue lies in test_dummy_encryption — it is an
> > implementation of fscrypt.
> > 
> > CC: linux-fscrypt
> > 
> > Thanks,
> 
> cc linux-fscrypt
> 
> -- 
> Julian Sun <sunjunchao@bytedance.com>
> 

It seems to be a known failure.  ext4/004, along with various other
tests, is excluded by
https://github.com/tytso/xfstests-bld/blob/master/test-appliance/files/root/fs/ext4/cfg/encrypt.exclude
as follows:

    ext4/004	// dump/restore doesn't handle quotas

I'm not sure why the comment mentions quotas.  It probably should say
"encryption", not "quotas".

Either way, the exclusion logic in xfstests-bld really should be
incorporated directly into xfstests, e.g. by using
_exclude_test_mount_option "test_dummy_encryption".

This seems to be a wider issue.  Effectively, ext4's exclusion lists for
xfstests are being maintained outside of xfstests itself.

- Eric

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-12-09 21:41 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-08  6:59 ext4/004 hangs with -o inlinecrypt,test_dummy_encryption Christoph Hellwig
2025-12-09  8:40 ` Julian Sun
2025-12-09  9:46   ` Julian Sun
2025-12-09 21:40     ` Eric Biggers

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox