From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: brauner@kernel.org, linux-ext4@vger.kernel.org,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/4] fs: send uevents for filesystem mount events
Date: Wed, 17 Dec 2025 21:26:41 -0800 [thread overview]
Message-ID: <aUOQkY3s_D_REIsH@infradead.org> (raw)
In-Reply-To: <176602332527.688213.9644123318095990966.stgit@frogsfrogsfrogs>
> +#define ADVANCE_ENV(envp, buf, buflen, written) \
> + do { \
> + ssize_t __written = (written); \
> +\
> + WARN_ON((buflen) < (__written) + 1); \
> + *(envp) = (buf); \
> + (envp)++; \
> + (buf) += (__written) + 1; \
> + (buflen) -= (__written) + 1; \
> + } while (0)
Any reason this is a macro vs an (inline?) function? Looking at this a
bit more, could this simply use a seq_buf?
next prev parent reply other threads:[~2025-12-18 5:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-18 2:02 [PATCHSET V4 2/2] fs: send uevents on mount and unmount Darrick J. Wong
2025-12-18 2:04 ` [PATCH 1/4] fs: send uevents for filesystem mount events Darrick J. Wong
2025-12-18 5:26 ` Christoph Hellwig [this message]
2025-12-18 19:49 ` Darrick J. Wong
2025-12-18 23:33 ` [PATCH V4.1 " Darrick J. Wong
2025-12-24 12:47 ` [PATCH " Christian Brauner
2025-12-26 23:58 ` Ian Kent
2026-01-05 17:26 ` Darrick J. Wong
2026-01-05 17:25 ` Darrick J. Wong
2025-12-18 2:04 ` [PATCH 2/4] xfs: send uevents when major filesystem events happen Darrick J. Wong
2025-12-18 5:27 ` Christoph Hellwig
2025-12-18 2:05 ` [PATCH 3/4] ext4: convert ext4_root to a kset Darrick J. Wong
2025-12-18 5:27 ` Christoph Hellwig
2025-12-18 2:05 ` [PATCH 4/4] ext4: send uevents when major filesystem events happen Darrick J. Wong
2025-12-18 5:27 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aUOQkY3s_D_REIsH@infradead.org \
--to=hch@infradead.org \
--cc=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox