From: jing zhang <zj.barak@gmail.com>
To: linux-ext4 <linux-ext4@vger.kernel.org>
Cc: "Theodore Ts'o" <tytso@mit.edu>, Andreas Dilger <adilger@sun.com>,
Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Subject: [PATCH] ext4: try fast merge operation in ext4_mb_free_metadata()
Date: Wed, 24 Mar 2010 21:32:39 +0800 [thread overview]
Message-ID: <ac8f92701003240632t2bcdb0b4l1d7543e3b1ffc9e7@mail.gmail.com> (raw)
From: Jing Zhang <zj.barak@gmail.com>
Date: Wed Mar 24 21:30:22 2010
There may exist fast path for merge if merge-able.
Cc: Theodore Ts'o <tytso@mit.edu>
Cc: Andreas Dilger <adilger@sun.com>
Cc: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Signed-off-by: Jing Zhang <zj.barak@gmail.com>
---
--- linux-2.6.32/fs/ext4/mballoc.c 2009-12-03 11:51:22.000000000 +0800
+++ ext4_mm_leak/mballoc7.c 2010-03-24 21:27:24.000000000 +0800
@@ -4385,6 +4385,24 @@ ext4_mb_free_metadata(handle_t *handle,
}
}
+ if (parent) {
+ /* let's try fast path */
+ entry = rb_entry(parent, struct ext4_free_data, node);
+ if (n == &parent->rb_left) {
+ if (can_merge(new_entry, entry)) {
+ entry->start_blk = new_entry->start_blk;
+ entry->count += new_entry->count;
+ /* and info the caller that new_entry is
+ * not used yet.
+ */
+ return 0;
+ }
+ }
+ else if (can_merge(entry, new_entry)) {
+ entry->count += new_entry->count;
+ return 0;
+ }
+ }
rb_link_node(new_node, parent, n);
rb_insert_color(new_node, &db->bb_free_root);
next reply other threads:[~2010-03-24 13:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-24 13:32 jing zhang [this message]
2010-03-24 17:04 ` [PATCH] ext4: try fast merge operation in ext4_mb_free_metadata() Aneesh Kumar K. V
2010-03-25 14:11 ` jing zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac8f92701003240632t2bcdb0b4l1d7543e3b1ffc9e7@mail.gmail.com \
--to=zj.barak@gmail.com \
--cc=adilger@sun.com \
--cc=linux-ext4@vger.kernel.org \
--cc=shaggy@linux.vnet.ibm.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).