From: jing zhang <zj.barak@gmail.com>
To: linux-ext4 <linux-ext4@vger.kernel.org>
Cc: "Theodore Ts'o" <tytso@mit.edu>, Andreas Dilger <adilger@sun.com>,
Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Subject: [PATCH] ext4: memory leakage in ext4_mb_free_blocks()
Date: Wed, 24 Mar 2010 21:55:55 +0800 [thread overview]
Message-ID: <ac8f92701003240655i32c5cfesf95651b96b812c66@mail.gmail.com> (raw)
From: Jing Zhang <zj.barak@gmail.com>
Date: Wed Mar 24 21:54:22 2010
There is memory leakage in ext4_mb_free_blocks(), if error, double
free of blocks, occurs in ext4_mb_free_metadata().
Cc: Theodore Ts'o <tytso@mit.edu>
Cc: Andreas Dilger <adilger@sun.com>
Cc: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Signed-off-by: Jing Zhang <zj.barak@gmail.com>
---
--- linux-2.6.32/fs/ext4/mballoc.c 2009-12-03 11:51:22.000000000 +0800
+++ ext4_mm_leak/mballoc8.c 2010-03-24 21:46:50.000000000 +0800
@@ -4419,7 +4419,8 @@ ext4_mb_free_metadata(handle_t *handle,
spin_lock(&sbi->s_md_lock);
list_add(&new_entry->list, &handle->h_transaction->t_private_list);
spin_unlock(&sbi->s_md_lock);
- return 0;
+ /* info the caller new_entry is used */
+ return 1;
}
/*
@@ -4547,7 +4548,8 @@ do_more:
ext4_lock_group(sb, block_group);
mb_clear_bits(bitmap_bh->b_data, bit, count);
- ext4_mb_free_metadata(handle, &e4b, new_entry);
+ if (0 == ext4_mb_free_metadata(handle, &e4b, new_entry))
+ kmem_cache_free(ext4_free_ext_cachep, new_entry);
} else {
/* need to update group_info->bb_free and bitmap
* with group lock held. generate_buddy look at
next reply other threads:[~2010-03-24 14:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-24 13:55 jing zhang [this message]
2010-03-24 17:01 ` [PATCH] ext4: memory leakage in ext4_mb_free_blocks() Aneesh Kumar K. V
2010-03-25 14:09 ` jing zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac8f92701003240655i32c5cfesf95651b96b812c66@mail.gmail.com \
--to=zj.barak@gmail.com \
--cc=adilger@sun.com \
--cc=linux-ext4@vger.kernel.org \
--cc=shaggy@linux.vnet.ibm.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).