From: jing zhang <zj.barak@gmail.com>
To: linux-ext4 <linux-ext4@vger.kernel.org>
Cc: "Theodore Ts'o" <tytso@mit.edu>, Andreas Dilger <adilger@sun.com>,
Dave Kleikamp <shaggy@linux.vnet.ibm.com>,
"Aneesh Kumar K. V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: [PATCH 1/2] ext4: try to relieve ext4_mb_discard_group_preallocations() from hard work in simple way
Date: Thu, 25 Mar 2010 23:24:13 +0800 [thread overview]
Message-ID: <ac8f92701003250824q6aeeac4cw55cb0d913e5a3bd3@mail.gmail.com> (raw)
From: Jing Zhang <zj.barak@gmail.com>
Date: Wed Mar 25 23:15:06 2010
The function, ext4_mb_discard_group_preallocations(), works alone as
hard as possible without correct understanding its caller's good
thinking.
And now try to relieve it in simple way.
But the variable, free, may be replaced with freed.
Cc: Theodore Ts'o <tytso@mit.edu>
Cc: Andreas Dilger <adilger@sun.com>
Cc: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Cc: "Aneesh Kumar K. V" <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: Jing Zhang <zj.barak@gmail.com>
---
--- linux-2.6.32/fs/ext4/mballoc.c 2009-12-03 11:51:22.000000000 +0800
+++ ext4_mm_leak/mballoc-11-1.c 2010-03-25 23:06:00.000000000 +0800
@@ -3633,7 +3633,7 @@ repeat:
spin_lock(&pa->pa_lock);
if (atomic_read(&pa->pa_count)) {
spin_unlock(&pa->pa_lock);
- busy = 1;
+ busy += 1;
continue;
}
if (pa->pa_deleted) {
@@ -3654,7 +3654,7 @@ repeat:
}
/* if we still need more blocks and some PAs were used, try again */
- if (free < needed && busy) {
+ if (free < needed && needed <= free + busy) {
busy = 0;
ext4_unlock_group(sb, group);
/*
next reply other threads:[~2010-03-25 15:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-25 15:24 jing zhang [this message]
2010-03-25 16:20 ` [PATCH 2/2] ext4: try to relieve ext4_mb_discard_group_preallocations() from hard work in simple way jing zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac8f92701003250824q6aeeac4cw55cb0d913e5a3bd3@mail.gmail.com \
--to=zj.barak@gmail.com \
--cc=adilger@sun.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=shaggy@linux.vnet.ibm.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).