From: Christoph Hellwig <hch@infradead.org>
To: Keith Busch <kbusch@meta.com>
Cc: linux-block@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org,
axboe@kernel.dk, jack@suse.cz, brauner@kernel.org,
cem@kernel.org, jaegeuk@kernel.org, aalbersh@kernel.org,
tytso@mit.edu, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCHv2 1/5] fs: add direct io attributes to file_getattr
Date: Mon, 13 Jul 2026 03:14:58 -0700 [thread overview]
Message-ID: <alS6oonYUoawuxBy@infradead.org> (raw)
In-Reply-To: <20260710210646.3576365-2-kbusch@meta.com>
On Fri, Jul 10, 2026 at 02:06:42PM -0700, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> Direct I/O imposes alignment and layout constraints that come from both
> the filesystem and its backing storage. statx() reports some of these,
> but not all, and it can no longer be extended.
Well, it could be extended. Although it would require a new flag,
and there's been a lot of pushback to adding non-fastpath attributes
to it. So maybe update this blurb ad bit and also mention which
attributes are duplicated?
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2026-07-13 10:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260710210646.3576365-1-kbusch@meta.com>
2026-07-10 21:53 ` [f2fs-dev] [PATCHv2 0/5] direct-io file extended attributes Eric Biggers
2026-07-10 22:58 ` Keith Busch
2026-07-11 0:24 ` Eric Biggers
2026-07-11 1:06 ` Keith Busch
[not found] ` <20260710210646.3576365-2-kbusch@meta.com>
2026-07-13 10:14 ` Christoph Hellwig [this message]
[not found] ` <20260710210646.3576365-3-kbusch@meta.com>
2026-07-13 11:57 ` [PATCHv2 2/5] block: report direct io attributes through file_getattr Christoph Hellwig
[not found] ` <20260710210646.3576365-4-kbusch@meta.com>
2026-07-13 12:00 ` [PATCHv2 3/5] xfs: " Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alS6oonYUoawuxBy@infradead.org \
--to=hch@infradead.org \
--cc=aalbersh@kernel.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=cem@kernel.org \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox