From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: typo in jbd2_journal_begin_ordered_truncate() Date: Tue, 3 Feb 2009 11:23:03 +0300 (EAT) Message-ID: Mime-Version: 1.0 Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII Cc: linux-ext4@vger.kernel.org To: sct@redhat.com, akpm@linux-foundation.org Return-path: Received: from mail-ew0-f21.google.com ([209.85.219.21]:54476 "EHLO mail-ew0-f21.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750998AbZBCIXY (ORCPT ); Tue, 3 Feb 2009 03:23:24 -0500 Received: by ewy14 with SMTP id 14so2278983ewy.13 for ; Tue, 03 Feb 2009 00:23:22 -0800 (PST) Sender: linux-ext4-owner@vger.kernel.org List-ID: This is jbd2_journal_begin_ordered_truncate() from fs/jbd2/transaction.c. I think the "&&" is supposed to be an "||" on line 2144. Just knowing that inode->i_transaction is NULL should be enough, otherwise we would immediately dereference a null on line 2146. 2144 if (!inode->i_transaction && !inode->i_next_transaction) 2145 goto out; 2146 journal = inode->i_transaction->t_journal; regards, dan carpenter