From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [PATCH 1/1] x86: fix text_poke Date: Fri, 25 Apr 2008 08:33:53 -0700 (PDT) Message-ID: References: <20080425.021301.193689806.davem@davemloft.net> <1209343883-7991-1-git-send-email-jirislaby@gmail.com> <20080425151931.GA25510@elte.hu> <20080425152650.GA894@elte.hu> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Jiri Slaby , David Miller , zdenek.kabelac@gmail.com, rjw@sisk.pl, paulmck@linux.vnet.ibm.com, akpm@linux-foundation.org, linux-ext4@vger.kernel.org, herbert@gondor.apana.org.au, penberg@cs.helsinki.fi, clameter@sgi.com, linux-kernel@vger.kernel.org, Mathieu Desnoyers , Andi Kleen , pageexec@freemail.hu, "H. Peter Anvin" , Jeremy Fitzhardinge To: Ingo Molnar Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:60863 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755825AbYDYPk4 (ORCPT ); Fri, 25 Apr 2008 11:40:56 -0400 In-Reply-To: <20080425152650.GA894@elte.hu> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Fri, 25 Apr 2008, Ingo Molnar wrote: > > something like the patch below? (untested) No. That whole code sequence is total and utter crap. It needs to be rewritten. It first does a BUG_ON() if it's not naturally aligned (because that wouldn't be atomic), and then it has code for page crossing! What a TOTAL PIECE OF SH*T! Hint: - if it's naturally aligned, it couldn't be page crossing ANYWAY - and if it was a page-crosser, it sure as hell couldn't be atomic! The code is just crap, crap, crap. It needs to be rewritten from scratch. I'll have a patch soonish. Linus