From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [RFC][PATCH] ext3: don't read inode block if the buffer has a write error Date: Mon, 23 Jun 2008 20:42:00 -0700 (PDT) Message-ID: References: <485F8822.5030205@hitachi.com> <20080623191733.52c3491c.akpm@linux-foundation.org> <200806241317.22470.nickpiggin@yahoo.com.au> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Andrew Morton , Hidehiro Kawai , sct@redhat.com, adilger@sun.com, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, jack@suse.cz, sugita , Satoshi OSHIMA To: Nick Piggin Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:56567 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752084AbYFXDmY (ORCPT ); Mon, 23 Jun 2008 23:42:24 -0400 In-Reply-To: <200806241317.22470.nickpiggin@yahoo.com.au> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Tue, 24 Jun 2008, Nick Piggin wrote: > > What you want to do is not insane, but the way it is currently being > done is. As I said, just clearing the uptodate bit might blow up your > kernel pretty quickly from assertions in the vm. It should be going > through the whole truncate or invalidate page machinery in order to > do that. Fair enough. I would not mind, for example, leaving the uptodate bit, but removing it from the radix tree or something like that (ie turning it into an anonymous page for a page-cache page, just removing it from the hash-queues for a buffer_head). Of course, that could cause other problems (eg any VM assertions that shared mappings only contain non-anon pages). Linus