From: Linus Torvalds <torvalds@linux-foundation.org>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: Don't use 'struct dentry' for internal lookups
Date: Sun, 21 Sep 2008 12:48:01 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.1.10.0809211241330.4475@nehalem.linux-foundation.org> (raw)
In-Reply-To: <E1KhEil-0004s7-Ve@closure.thunk.org>
On Sat, 20 Sep 2008, Theodore Ts'o wrote:
>
> Linus, I plan to push this to you at the next patch window; I'm just
> cc'ing you now since you authored the original patch.
>
> It seems that the ext3 version of the patch seems not to have been
> picked up by akpm. Want me to resend it to him?
That would be good. I guess we don't have any ext3 maintainer. But I also
wouldn't object to just getting it through you if you want to.
> Also, per your complaints about the stack-heavy ext3 users, one fairly
> easy fix for x86_64 (the stack usage isn't all that bad on x86 when
> pointers are only 32-bits) is pretty much all of the places where we use
> "unsigned long" in fs/ext3 should be safely replaceable by "unsigned
> int" or "u32". Sigh...
Somebody who knows the code should check it out, but yes.. I just checked
that at least some versions of gcc will do the right thing, and only spill
in 32 bits (I was worried that maybe gcc would end up spilling the whole
64-bit register anyway).
Linus
next prev parent reply other threads:[~2008-09-21 19:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-21 2:30 [PATCH] ext4: Don't use 'struct dentry' for internal lookups Theodore Ts'o
2008-09-21 19:48 ` Linus Torvalds [this message]
2008-09-21 20:17 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0809211241330.4475@nehalem.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox