From: Linus Torvalds <torvalds@linux-foundation.org>
To: David Howells <dhowells@redhat.com>
Cc: akpm@linux-foundation.org, linux-ext4@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Ext4: Don't ask about supporting ext2/3 in ext4 if ext4 is not configured
Date: Mon, 14 Dec 2009 10:10:22 -0800 (PST) [thread overview]
Message-ID: <alpine.LFD.2.00.0912141007410.26135@localhost.localdomain> (raw)
In-Reply-To: <20091214135546.10111.4495.stgit@warthog.procyon.org.uk>
On Mon, 14 Dec 2009, David Howells wrote:
> config EXT4_USE_FOR_EXT23
> bool "Use ext4 for ext2/ext3 file systems"
> - depends on EXT3_FS=n || EXT2_FS=n
> + depends on EXT4_FS && (EXT3_FS=n || EXT2_FS=n)
Side note: I think we should actively avoid complex config dependency
expressions.
The above can be written with simpler expressions by just splitting it in
two, and I think it makes it more readable:
depends on EXT4_FS
depends on EXT3_FS=n || EXT2_FS=n
since the two expressions are logically totally unrelated: one is just the
obvious "this kconfig doesn't make sense without ext4" thing that was
missing before, and the other is a totally unrelated "if you already have
selected ext2 and ext3, then you clearly don't want ext4 to deal with
them".
Linus
prev parent reply other threads:[~2009-12-14 18:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-14 13:55 [PATCH] Ext4: Don't ask about supporting ext2/3 in ext4 if ext4 is not configured David Howells
2009-12-14 14:30 ` tytso
2009-12-14 18:10 ` Linus Torvalds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0912141007410.26135@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox