From: Lukas Czerner <lczerner@redhat.com>
To: Yargil <yargil@free.fr>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH v2] ext4: don't work without procfs
Date: Wed, 5 Oct 2011 15:00:45 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.00.1110051456440.4423@dhcp-27-109.brq.redhat.com> (raw)
In-Reply-To: <1317743049-4641-1-git-send-email-yargil@free.fr>
On Tue, 4 Oct 2011, Yargil wrote:
> Regression from commit dd68314ccf3fb918c1fb6471817edbc60ece4b52
> The problem come from the test of the return value of proc_mkdir
> that is always false without procfs and abort the init of ext4.
Looks good. Thanks!
Reviewed-by: Lukas Czerner <lczerner@redhat.com>
> ---
> fs/ext4/super.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 44d0c8d..9b51b17 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -4985,8 +4985,10 @@ static int __init ext4_init_fs(void)
> if (!ext4_kset)
> goto out6;
> ext4_proc_root = proc_mkdir("fs/ext4", NULL);
> +#ifdef CONFIG_PROC_FS
> if (!ext4_proc_root)
> goto out5;
> +#endif
>
> err = ext4_init_feat_adverts();
> if (err)
>
--
next prev parent reply other threads:[~2011-10-05 13:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-04 15:44 [PATCH v2] ext4: don't work without procfs Yargil
2011-10-05 13:00 ` Lukas Czerner [this message]
2011-10-06 12:48 ` yargil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1110051456440.4423@dhcp-27-109.brq.redhat.com \
--to=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=yargil@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox