From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-15?Q?Luk=E1=A8_Czerner?= Subject: Re: [PATCH] ext4: enable FITRIM ioctl on bigalloc file system Date: Wed, 12 Sep 2012 11:31:46 -0400 (EDT) Message-ID: References: <1341342642-4156-1-git-send-email-lczerner@redhat.com> Mime-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="-1463810303-2067829690-1347463908=:2222" Cc: linux-ext4@vger.kernel.org, tytso@mit.edu To: =?ISO-8859-15?Q?Luk=E1=A8_Czerner?= Return-path: Received: from mx1.redhat.com ([209.132.183.28]:16988 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759999Ab2ILPbu (ORCPT ); Wed, 12 Sep 2012 11:31:50 -0400 In-Reply-To: Sender: linux-ext4-owner@vger.kernel.org List-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1463810303-2067829690-1347463908=:2222 Content-Type: TEXT/PLAIN; charset=ISO-8859-15 Content-Transfer-Encoding: 8BIT On Tue, 21 Aug 2012, LukᨠCzerner wrote: > Date: Tue, 21 Aug 2012 11:48:27 +0200 (CEST) > From: LukᨠCzerner > To: Lukas Czerner > Cc: linux-ext4@vger.kernel.org, tytso@mit.edu > Subject: Re: [PATCH] ext4: enable FITRIM ioctl on bigalloc file system > > On Tue, 3 Jul 2012, Lukas Czerner wrote: > > > Date: Tue, 3 Jul 2012 21:10:42 +0200 > > From: Lukas Czerner > > To: linux-ext4@vger.kernel.org > > Cc: tytso@mit.edu, Lukas Czerner > > Subject: [PATCH] ext4: enable FITRIM ioctl on bigalloc file system > > > > With a minor tweaks regarding minimum extent size to discard and > > discarded bytes reporting the FITRIM can be enabled on bigalloc file > > system and it works without any problem. > > > > This patch fixes minlen handling and discarded bytes reporting to > > take into consideration bigalloc enabled file systems and finally > > removes the restriction and allow FITRIM to be used on file system with > > bigalloc feature enabled. > > any comments on this ? > > Thanks! > -Lukas ping^2 > > > > Signed-off-by: Lukas Czerner > > --- > > fs/ext4/ioctl.c | 7 ------- > > fs/ext4/mballoc.c | 5 +++-- > > 2 files changed, 3 insertions(+), 9 deletions(-) > > > > diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c > > index e34deac..9d6e0bc 100644 > > --- a/fs/ext4/ioctl.c > > +++ b/fs/ext4/ioctl.c > > @@ -420,13 +420,6 @@ resizefs_out: > > if (!blk_queue_discard(q)) > > return -EOPNOTSUPP; > > > > - if (EXT4_HAS_RO_COMPAT_FEATURE(sb, > > - EXT4_FEATURE_RO_COMPAT_BIGALLOC)) { > > - ext4_msg(sb, KERN_ERR, > > - "FITRIM not supported with bigalloc"); > > - return -EOPNOTSUPP; > > - } > > - > > if (copy_from_user(&range, (struct fstrim_range __user *)arg, > > sizeof(range))) > > return -EFAULT; > > diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c > > index 1cd6994..c4bd0a6 100644 > > --- a/fs/ext4/mballoc.c > > +++ b/fs/ext4/mballoc.c > > @@ -4984,7 +4984,8 @@ int ext4_trim_fs(struct super_block *sb, struct fstrim_range *range) > > > > start = range->start >> sb->s_blocksize_bits; > > end = start + (range->len >> sb->s_blocksize_bits) - 1; > > - minlen = range->minlen >> sb->s_blocksize_bits; > > + minlen = EXT4_NUM_B2C(EXT4_SB(sb), > > + range->minlen >> sb->s_blocksize_bits); > > > > if (unlikely(minlen > EXT4_CLUSTERS_PER_GROUP(sb)) || > > unlikely(start >= max_blks)) > > @@ -5044,6 +5045,6 @@ int ext4_trim_fs(struct super_block *sb, struct fstrim_range *range) > > atomic_set(&EXT4_SB(sb)->s_last_trim_minblks, minlen); > > > > out: > > - range->len = trimmed * sb->s_blocksize; > > + range->len = EXT4_C2B(EXT4_SB(sb), trimmed) << sb->s_blocksize_bits; > > return ret; > > } > > > ---1463810303-2067829690-1347463908=:2222--