From: "Lukáš Czerner" <lczerner@redhat.com>
To: Tomas Racek <tracek@redhat.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] e2fsprogs: fix flag settings in e2image.h
Date: Thu, 21 Feb 2013 14:00:53 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.2.00.1302211356490.19354@localhost> (raw)
In-Reply-To: <1361448418-26688-1-git-send-email-tracek@redhat.com>
On Thu, 21 Feb 2013, Tomas Racek wrote:
> Date: Thu, 21 Feb 2013 13:06:58 +0100
> From: Tomas Racek <tracek@redhat.com>
> To: linux-ext4@vger.kernel.org
> Cc: Tomas Racek <tracek@redhat.com>
> Subject: [PATCH] e2fsprogs: fix flag settings in e2image.h
>
> This prevents from SIGSEGV when -s options is used.
oops! Thanks for catching that. I just wonder why the regression
test is not catching that ?
you can add
Reviewed-by: Lukas Czerner <lczerner@redhat.com>
>
> Signed-off-by: Tomas Racek <tracek@redhat.com>
> ---
> lib/ext2fs/e2image.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/ext2fs/e2image.h b/lib/ext2fs/e2image.h
> index c918529..5537980 100644
> --- a/lib/ext2fs/e2image.h
> +++ b/lib/ext2fs/e2image.h
> @@ -19,7 +19,7 @@
> /* Image flags */
> #define E2IMAGE_INSTALL_FLAG 1
> #define E2IMAGE_SCRAMBLE_FLAG 2
> -#define E2IMAGE_IS_QCOW2_FLAG 3
> +#define E2IMAGE_IS_QCOW2_FLAG 4
>
> struct ext2_image_hdr {
> __u32 magic_number; /* This must be EXT2_ET_MAGIC_E2IMAGE */
>
next prev parent reply other threads:[~2013-02-21 13:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-21 12:06 [PATCH] e2fsprogs: fix flag settings in e2image.h Tomas Racek
2013-02-21 13:00 ` Lukáš Czerner [this message]
2013-02-28 20:11 ` Tomas Racek
2013-04-22 3:49 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1302211356490.19354@localhost \
--to=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tracek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).