From: "Lukáš Czerner" <lczerner@redhat.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: Lukas Czerner <lczerner@redhat.com>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/3] ext4: Use kstrtoul() instead of deprecated simple_strtoul()
Date: Mon, 11 Mar 2013 08:36:16 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.2.00.1303110830260.24359@localhost> (raw)
In-Reply-To: <20130311022635.GG10090@thunk.org>
On Sun, 10 Mar 2013, Theodore Ts'o wrote:
> Date: Sun, 10 Mar 2013 22:26:35 -0400
> From: Theodore Ts'o <tytso@mit.edu>
> To: Lukas Czerner <lczerner@redhat.com>
> Cc: linux-ext4@vger.kernel.org
> Subject: Re: [PATCH 2/3] ext4: Use kstrtoul() instead of deprecated
> simple_strtoul()
>
> On Fri, Mar 08, 2013 at 09:23:17AM +0100, Lukas Czerner wrote:
> > In parse_strtoul() we're still using deprecated simple_strtoul(). Change
> > that in favour of kstrtoul().
> >
> > Signed-off-by: Lukas Czerner <lczerner@redhat.com>
>
> Once you make this change, wouldn't it be better and even more
> simplifying to replace the two places where we call parse_strtoul()
> with kstrtoul()?
>
> - Ted
I think that parse_strtoul() is still useful to have because we
check the "max" value as well and return -EINVAL if it is exceeded.
Removing it we would have to add the check to the callers
where we're using is now, which seems unnecessary, especially since
we might expect more users of the helper.
-Lukas
next prev parent reply other threads:[~2013-03-11 7:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-08 8:23 [PATCH 1/3] ext4: remove unused variable in ext4_free_blocks() Lukas Czerner
2013-03-08 8:23 ` [PATCH 2/3] ext4: Use kstrtoul() instead of deprecated simple_strtoul() Lukas Czerner
2013-03-11 2:26 ` Theodore Ts'o
2013-03-11 7:36 ` Lukáš Czerner [this message]
2013-03-11 15:38 ` Theodore Ts'o
2013-03-08 8:23 ` [PATCH 3/3] ext4: Do no use yield() in ext4 code Lukas Czerner
2013-03-11 2:41 ` Theodore Ts'o
2013-03-11 2:25 ` [PATCH 1/3] ext4: remove unused variable in ext4_free_blocks() Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1303110830260.24359@localhost \
--to=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).