linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Lukáš Czerner" <lczerner@redhat.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: Lukas Czerner <lczerner@redhat.com>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] mke2fs: Disallow bigalloc with with bs < 4096
Date: Wed, 3 Apr 2013 16:47:55 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.2.00.1304031645010.10110@localhost> (raw)
In-Reply-To: <20130403143554.GA13668@thunk.org>

On Wed, 3 Apr 2013, Theodore Ts'o wrote:

> Date: Wed, 3 Apr 2013 10:35:54 -0400
> From: Theodore Ts'o <tytso@mit.edu>
> To: Lukas Czerner <lczerner@redhat.com>
> Cc: linux-ext4@vger.kernel.org
> Subject: Re: [PATCH] mke2fs: Disallow bigalloc with with bs < 4096
> 
> On Wed, Apr 03, 2013 at 03:51:39PM +0200, Lukas Czerner wrote:
> > Currently there is nothing preventing user to create file system with
> > bigalloc feature enabled and block size smaller than 4096 Bytes. However
> > such combination does not make much sense at all because the whole point
> > of bigalloc is to have bigger allocation units.
> > 
> > This patch disallow such combination.
> 
> This makes sense by default but I do see a point in allowing it for
> testing purposes --- specifically, it allows us to verify that
> bigalloc works on architectures such as PowerPC and Itanium where page
> size is greater than the 4k block size.  So maybe a developer mode set
> via mke2fs.conf?

Yes, I though about that and I wanted to know what the general
opinion is. I'll prepare the patch which makes this tunable,
but restricted by default.

> 
> Another option would be to enforce that we only support bigalloc file
> systems where the blocksize == pagesize, but that means we wouldn't be
> able to mount 4k bigalloc file systems on architectures with a 8k or
> 16k page size.

Unfortunately we can't do that for the reasons you mentioned.

Thanks!
-Lukas

> 
> 						- Ted
> 

      reply	other threads:[~2013-04-03 14:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-03 13:51 [PATCH] mke2fs: Disallow bigalloc with with bs < 4096 Lukas Czerner
2013-04-03 14:35 ` Theodore Ts'o
2013-04-03 14:47   ` Lukáš Czerner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.1304031645010.10110@localhost \
    --to=lczerner@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).