Re: [PATCH v4 20/20] ext4: Allow punch hole with bigalloc enabled

Theodore Ts'o
2013-05-31T15:14:54Z

On Tue, May 14, 2013 at 06:37:34PM +0200, Lukas Czerner wrote:
> In commits 5f95d21fb6f2aaa52830e5b7fb405f6c71d3ab85 and
> 30bc2ec9598a1b156ad75217f2e7d4560efdeeab we've reworked punch_hole
> implementation and there is noting holding us back from using punch hole
> on file system with bigalloc feature enabled.
>
> This has been tested with fsx and xfstests.
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
> Reviewed-by: Jan Kara <jack@suse.cz>

This patch is causing a test failure with bigalloc enabled with the
xfstests shared/298.

Since it's at the end of the invalidate page range tests, I'm going to
drop this patch for now. Could you take a look at this?

Thanks!!

- Ted