Re: [PATCH v4 15/20] ext4: use ext4_zero_partial_blocks in punch_hole

Theodore Ts'o
2013-06-19T23:42:46Z

On Wed, Jun 19, 2013 at 06:37:53PM +0200, Lukáš Czerner wrote:
>
> I think I've got this. The problem actually is in
> ext4_zero_partial_blocks() where we would attempt to zero out page
> which has been previously released by truncate_pagecache_range().
> This might happen when we're punching out just a single page because
> in ext4_zero_partial_blocks() we do not check whether we're dealing
> with the whole, or partial page. At the point we're going to zero it
> out it might have been already released and reused by someone else.
>
> This patch should fix this issue. And indeed with this applied I do
> not see the problem anymore but I am still testing.

Thanks for finding this! I'm still doing testing of your trial patch
myself, but initial results seem to indicate that this also solves the
failures 269 and 270 which was apparently uncovered by Ashish's patch
"ext4: optimize extent selection for block removal in case of hole
punch".

- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html