Re: [PATCH 15/31] e2fsck: Teach EA refcounting code to handle 48bit block addresses

Theodore Ts'o
2013-10-08T16:01:24Z

On Mon, Oct 07, 2013 at 11:37:43AM -0700, Darrick J. Wong wrote:
> > I am not sure if we really need count, size and cursor to be blk_t
> > let alone blk64_t. It's a bit misleading because AFAICT those
> > variable does not represent block numbers at all. Maybe it should be
> > changed to something less confusing, preferably matching the actual
> > xattr implementation ?
>
> Oops, I got a little too s/blk_t/blk64_t/ happy there. Those could be __u32, I
> think. Or unsigned long.

__u32 should be fine, yes. Could you send me an updated patch?

Thanks,

- Ted