Re: [PATCH 02/31] libext2fs: Only link an inode into a directory once

Theodore Ts'o
2013-10-07T13:17:29Z

On Mon, Sep 30, 2013 at 06:26:55PM -0700, Darrick J. Wong wrote:
> The ext2fs_link helper function link_proc does not check the value of ls->done,
> which means that if the function finds multiple empty spaces that will fit the
> new directory entry, it will create a directory entry in each of the spaces.
> Instead of doing that, check the done value and don't do anything more if we've
> already added the directory entry.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

Thanks, applied.

One minor nit, which I'll generally fix myself when I have the chance:

I generally like to fill comments at column 70, and in general, to try
to keep the summary line under 76 columns if possible, so that "git
log" doesn't wrap on 80 column screens. It's not always possible to
do the latter, but it's something I will try to do. Also, personally
prefer to use a lowercase to start the description since these
constraints generally mean the summary line can't be a complete
sentence.

- Ted