[PATCH 02/31] libext2fs: Only link an inode into a directory once

Darrick J. Wong
2013-10-01T01:26:59Z

The ext2fs_link helper function link_proc does not check the value of ls->done,
which means that if the function finds multiple empty spaces that will fit the
new directory entry, it will create a directory entry in each of the spaces.
Instead of doing that, check the done value and don't do anything more if we've
already added the directory entry.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
lib/ext2fs/link.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/lib/ext2fs/link.c b/lib/ext2fs/link.c
index f715067..e3ff450 100644
--- a/lib/ext2fs/link.c
+++ b/lib/ext2fs/link.c
@@ -43,6 +43,9 @@ static int link_proc(struct ext2_dir_entry *dirent,
int ret = 0;
int csum_size = 0;

+ if (ls->done)
+ return 0;
+
rec_len = EXT2_DIR_REC_LEN(ls->namelen);

ls->err = ext2fs_get_rec_len(ls->fs, dirent, &curr_rec_len);