From: "Lukáš Czerner" <lczerner@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: tytso@mit.edu, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 02/25] libext2fs: fix ext2fs_open2() truncation of the superblock parameter
Date: Wed, 23 Oct 2013 16:49:19 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.00.1310231648450.1918@localhost.localdomain> (raw)
In-Reply-To: <20131018183204.GB19188@birch.djwong.org>
On Fri, 18 Oct 2013, Darrick J. Wong wrote:
> Date: Fri, 18 Oct 2013 11:32:04 -0700
> From: Darrick J. Wong <darrick.wong@oracle.com>
> To: tytso@mit.edu
> Cc: linux-ext4@vger.kernel.org
> Subject: Re: [PATCH 02/25] libext2fs: fix ext2fs_open2() truncation of the
> superblock parameter
>
> On Thu, Oct 17, 2013 at 09:49:07PM -0700, Darrick J. Wong wrote:
> > Since it's possible for very large filesystems to store backup
> > superblocks at very large (> 2^32) block numbers, we need to be able
> > to handle the case of a caller directing us to read one of these
> > high-numbered backups.
Looks good.
Reviewed-by: Lukas Czerner <lczerner@redhat.com>
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> > ---
> > debugfs/debugfs.c | 4 ++--
> > e2fsck/journal.c | 6 +++---
> > e2fsck/unix.c | 8 ++++----
> > lib/ext2fs/ext2fs.h | 4 ++++
> > lib/ext2fs/openfs.c | 21 +++++++++++++++------
> > misc/dumpe2fs.c | 4 ++--
> > 6 files changed, 30 insertions(+), 17 deletions(-)
> >
> >
> > diff --git a/debugfs/debugfs.c b/debugfs/debugfs.c
> > index 8c32eff..4f6108d 100644
> > --- a/debugfs/debugfs.c
> > +++ b/debugfs/debugfs.c
> > @@ -94,8 +94,8 @@ static void open_filesystem(char *device, int open_flags, blk64_t superblock,
> > if (catastrophic)
> > open_flags |= EXT2_FLAG_SKIP_MMP;
> >
> > - retval = ext2fs_open(device, open_flags, superblock, blocksize,
> > - unix_io_manager, ¤t_fs);
> > + retval = ext2fs_open3(device, NULL, open_flags, superblock, blocksize,
> > + unix_io_manager, ¤t_fs);
> > if (retval) {
> > com_err(device, retval, "while opening filesystem");
> > current_fs = NULL;
> > diff --git a/e2fsck/journal.c b/e2fsck/journal.c
> > index 2509303..af35a38 100644
> > --- a/e2fsck/journal.c
> > +++ b/e2fsck/journal.c
> > @@ -967,9 +967,9 @@ int e2fsck_run_ext3_journal(e2fsck_t ctx)
> >
> > ext2fs_mmp_stop(ctx->fs);
> > ext2fs_free(ctx->fs);
> > - retval = ext2fs_open(ctx->filesystem_name, EXT2_FLAG_RW,
> > - ctx->superblock, blocksize, io_ptr,
> > - &ctx->fs);
> > + retval = ext2fs_open3(ctx->filesystem_name, NULL, EXT2_FLAG_RW,
> > + ctx->superblock, blocksize, io_ptr,
> > + &ctx->fs);
> > if (retval) {
> > com_err(ctx->program_name, retval,
> > _("while trying to re-open %s"),
> > diff --git a/e2fsck/unix.c b/e2fsck/unix.c
> > index 0546653..fb41ca0 100644
> > --- a/e2fsck/unix.c
> > +++ b/e2fsck/unix.c
> > @@ -1040,7 +1040,7 @@ static errcode_t try_open_fs(e2fsck_t ctx, int flags, io_manager io_ptr,
> >
> > *ret_fs = NULL;
> > if (ctx->superblock && ctx->blocksize) {
> > - retval = ext2fs_open2(ctx->filesystem_name, ctx->io_options,
> > + retval = ext2fs_open3(ctx->filesystem_name, ctx->io_options,
> > flags, ctx->superblock, ctx->blocksize,
> > io_ptr, ret_fs);
> > } else if (ctx->superblock) {
> > @@ -1051,7 +1051,7 @@ static errcode_t try_open_fs(e2fsck_t ctx, int flags, io_manager io_ptr,
> > ext2fs_free(*ret_fs);
> > *ret_fs = NULL;
> > }
> > - retval = ext2fs_open2(ctx->filesystem_name,
> > + retval = ext2fs_open3(ctx->filesystem_name,
> > ctx->io_options, flags,
> > ctx->superblock, blocksize,
> > io_ptr, ret_fs);
> > @@ -1059,7 +1059,7 @@ static errcode_t try_open_fs(e2fsck_t ctx, int flags, io_manager io_ptr,
> > break;
> > }
> > } else
> > - retval = ext2fs_open2(ctx->filesystem_name, ctx->io_options,
> > + retval = ext2fs_open3(ctx->filesystem_name, ctx->io_options,
> > flags, 0, 0, io_ptr, ret_fs);
> >
> > if (retval == 0)
> > @@ -1375,7 +1375,7 @@ failure:
> > * don't need to update the mount count and last checked
> > * fields in the backup superblock (the kernel doesn't update
> > * the backup superblocks anyway). With newer versions of the
> > - * library this flag is set by ext2fs_open2(), but we set this
> > + * library this flag is set by ext2fs_open3(), but we set this
> > * here just to be sure. (No, we don't support e2fsck running
> > * with some other libext2fs than the one that it was shipped
> > * with, but just in case....)
> > diff --git a/lib/ext2fs/ext2fs.h b/lib/ext2fs/ext2fs.h
> > index 67876ad..1ef4d67 100644
> > --- a/lib/ext2fs/ext2fs.h
> > +++ b/lib/ext2fs/ext2fs.h
> > @@ -1443,6 +1443,10 @@ extern errcode_t ext2fs_open2(const char *name, const char *io_options,
> > int flags, int superblock,
> > unsigned int block_size, io_manager manager,
> > ext2_filsys *ret_fs);
> > +extern errcode_t ext2fs_open3(const char *name, const char *io_options,
> > + int flags, blk64_t superblock,
> > + unsigned int block_size, io_manager manager,
> > + ext2_filsys *ret_fs);
> > extern blk64_t ext2fs_descriptor_block_loc2(ext2_filsys fs,
> > blk64_t group_block, dgrp_t i);
> > extern blk_t ext2fs_descriptor_block_loc(ext2_filsys fs, blk_t group_block,
> > diff --git a/lib/ext2fs/openfs.c b/lib/ext2fs/openfs.c
> > index 2ad9114..b046d6c 100644
> > --- a/lib/ext2fs/openfs.c
> > +++ b/lib/ext2fs/openfs.c
> > @@ -76,6 +76,15 @@ errcode_t ext2fs_open(const char *name, int flags, int superblock,
> > manager, ret_fs);
> > }
> >
> > +errcode_t ext2fs_open2(const char *name, const char *io_options,
> > + int flags, int superblock,
> > + unsigned int block_size, io_manager manager,
> > + ext2_filsys *ret_fs)
> > +{
> > + return ext2fs_open3(name, io_options, flags, superblock, block_size,
> > + manager, ret_fs);
> > +}
> > +
> > /*
> > * Note: if superblock is non-zero, block-size must also be non-zero.
> > * Superblock and block_size can be zero to use the default size.
> > @@ -90,8 +99,8 @@ errcode_t ext2fs_open(const char *name, int flags, int superblock,
> > * EXT2_FLAG_64BITS - Allow 64-bit bitfields (needed for large
> > * filesystems)
> > */
> > -errcode_t ext2fs_open2(const char *name, const char *io_options,
> > - int flags, int superblock,
> > +errcode_t ext2fs_open3(const char *name, const char *io_options,
> > + int flags, blk64_t superblock,
> > unsigned int block_size, io_manager manager,
> > ext2_filsys *ret_fs)
> > {
> > @@ -189,8 +198,8 @@ errcode_t ext2fs_open2(const char *name, const char *io_options,
> > if (retval)
> > goto cleanup;
> > }
> > - retval = io_channel_read_blk(fs->io, superblock, -SUPERBLOCK_SIZE,
> > - fs->super);
> > + retval = io_channel_read_blk64(fs->io, superblock, -SUPERBLOCK_SIZE,
> > + fs->super);
> > if (retval)
> > goto cleanup;
> > if (fs->orig_super)
> > @@ -380,8 +389,8 @@ errcode_t ext2fs_open2(const char *name, const char *io_options,
> > else
> > first_meta_bg = fs->desc_blocks;
> > if (first_meta_bg) {
> > - retval = io_channel_read_blk(fs->io, group_block+1,
> > - first_meta_bg, dest);
> > + retval = io_channel_read_blk64(fs->io, group_block+1,
> > + first_meta_bg, dest);
>
> The only change to this patch is the use of *read_blk64 in these two hunks.
>
> --D
>
> > if (retval)
> > goto cleanup;
> > #ifdef WORDS_BIGENDIAN
> > diff --git a/misc/dumpe2fs.c b/misc/dumpe2fs.c
> > index ae70f70..b139977 100644
> > --- a/misc/dumpe2fs.c
> > +++ b/misc/dumpe2fs.c
> > @@ -611,7 +611,7 @@ int main (int argc, char ** argv)
> > for (use_blocksize = EXT2_MIN_BLOCK_SIZE;
> > use_blocksize <= EXT2_MAX_BLOCK_SIZE;
> > use_blocksize *= 2) {
> > - retval = ext2fs_open (device_name, flags,
> > + retval = ext2fs_open3(device_name, NULL, flags,
> > use_superblock,
> > use_blocksize, unix_io_manager,
> > &fs);
> > @@ -619,7 +619,7 @@ int main (int argc, char ** argv)
> > break;
> > }
> > } else
> > - retval = ext2fs_open (device_name, flags, use_superblock,
> > + retval = ext2fs_open3(device_name, NULL, flags, use_superblock,
> > use_blocksize, unix_io_manager, &fs);
> > if (retval) {
> > com_err (program_name, retval, _("while trying to open %s"),
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2013-10-23 14:49 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 4:48 [PATCH v2 00/25] e2fsprogs patchbomb 10/2013 Darrick J. Wong
2013-10-18 4:49 ` [PATCH 01/25] libext2fs: stop iterating dirents when done linking Darrick J. Wong
2013-10-23 23:39 ` Theodore Ts'o
2013-10-18 4:49 ` [PATCH 02/25] libext2fs: fix ext2fs_open2() truncation of the superblock parameter Darrick J. Wong
2013-10-18 18:32 ` Darrick J. Wong
2013-10-23 14:49 ` Lukáš Czerner [this message]
2013-10-18 4:49 ` [PATCH 03/25] mke2fs: don't let resize= turn on resize_inode when meta_bg is set Darrick J. Wong
2013-10-23 15:08 ` Lukáš Czerner
2013-10-23 23:40 ` Theodore Ts'o
2013-10-18 4:49 ` [PATCH 04/25] libext2fs: reject 64bit badblocks numbers Darrick J. Wong
2013-10-23 15:24 ` Lukáš Czerner
2013-10-23 23:58 ` Theodore Ts'o
2013-10-24 11:40 ` Lukáš Czerner
2013-10-18 4:49 ` [PATCH 05/25] libext2fs: don't overflow when punching indirect blocks with large blocks Darrick J. Wong
2013-10-24 0:08 ` Theodore Ts'o
2013-12-04 4:40 ` Darrick J. Wong
2013-10-18 4:49 ` [PATCH 06/25] libext2fs: fix tests that set LARGE_FILE Darrick J. Wong
2013-11-25 7:09 ` Zheng Liu
2013-11-25 17:57 ` Darrick J. Wong
2013-10-18 4:49 ` [PATCH 07/25] mke2fs: load configfile blocksize setting before 64bit checks Darrick J. Wong
2013-11-25 8:01 ` Zheng Liu
2013-10-18 4:49 ` [PATCH 08/25] debugfs: fix various minor bogosity Darrick J. Wong
2013-11-25 8:08 ` Zheng Liu
2013-11-25 18:05 ` Darrick J. Wong
2013-10-18 4:49 ` [PATCH 09/25] e2fsck: teach EA refcounting code to handle 64bit block addresses Darrick J. Wong
2013-10-18 18:37 ` Darrick J. Wong
2013-11-25 8:18 ` Zheng Liu
2013-10-18 4:50 ` [PATCH 10/25] debugfs: handle 64bit block numbers Darrick J. Wong
2013-10-18 18:47 ` Darrick J. Wong
2013-11-25 8:33 ` Zheng Liu
2013-11-25 17:49 ` Darrick J. Wong
2013-10-18 4:50 ` [PATCH 11/25] libext2fs: only punch complete clusters Darrick J. Wong
2013-10-18 18:55 ` Darrick J. Wong
2013-11-25 8:51 ` Zheng Liu
2013-10-18 4:50 ` [PATCH 12/25] libext2fs: don't update the summary counts when doing implied cluster allocation Darrick J. Wong
2013-11-25 9:03 ` Zheng Liu
2013-10-18 4:50 ` [PATCH 13/25] libext2fs: use ext2fs_punch() to truncate quota file Darrick J. Wong
2013-11-25 9:08 ` Zheng Liu
2013-10-18 4:50 ` [PATCH 14/25] e2fsck: only release clusters when shortening a directory during a rehash Darrick J. Wong
2013-11-25 11:09 ` Zheng Liu
2013-10-18 4:50 ` [PATCH 15/25] e2fsck: print cluster ranges when encountering bitmap errors Darrick J. Wong
2013-11-25 11:56 ` Zheng Liu
2013-10-18 4:50 ` [PATCH 16/25] resize2fs: convert fs to and from 64bit mode Darrick J. Wong
2013-10-18 18:59 ` Darrick J. Wong
2013-11-26 6:44 ` Zheng Liu
2013-11-26 18:39 ` Darrick J. Wong
2013-11-27 2:21 ` Zheng Liu
2013-10-18 4:50 ` [PATCH 17/25] resize2fs: when toggling 64bit, don't free in-use bg data clusters Darrick J. Wong
2013-10-18 4:50 ` [PATCH 18/25] resize2fs: adjust reserved_gdt_blocks when changing group descriptor size Darrick J. Wong
2013-10-18 4:51 ` [PATCH 19/25] resize2fs: during shrink, don't free in-use bg data clusters Darrick J. Wong
2013-10-18 4:51 ` [PATCH 20/25] resize2fs: don't free in-use clusters when moving blocks Darrick J. Wong
2013-10-18 4:51 ` [PATCH 21/25] misc: use the checksum predicate function, not raw flag tests Darrick J. Wong
2013-10-18 4:51 ` [PATCH 22/25] resize2fs: rewrite extent/dir/ea block checksums when migrating Darrick J. Wong
2013-10-18 4:51 ` [PATCH 23/25] libext2fs: support modifying arbitrary extended attributes Darrick J. Wong
2013-10-18 19:25 ` Darrick J. Wong
2013-10-22 1:13 ` Darrick J. Wong
2013-11-26 7:21 ` Zheng Liu
2013-11-26 19:55 ` Darrick J. Wong
2013-11-27 2:52 ` Zheng Liu
2013-11-27 3:13 ` Darrick J. Wong
2013-11-27 11:36 ` Zheng Liu
2013-11-27 1:56 ` Darrick J. Wong
2013-11-29 5:30 ` Zheng Liu
2013-11-29 8:17 ` Jan Kara
2013-11-30 20:24 ` Darrick J. Wong
2013-12-02 8:38 ` Jan Kara
2013-10-18 4:51 ` [PATCH 24/25] misc: add fuse2fs, a FUSE server for e2fsprogs Darrick J. Wong
2013-10-18 19:36 ` Darrick J. Wong
2013-10-22 1:20 ` Darrick J. Wong
2013-10-18 13:13 ` [PATCH v2 00/25] e2fsprogs patchbomb 10/2013 Lukáš Czerner
2013-10-18 18:13 ` Darrick J. Wong
2013-10-18 20:37 ` Darrick J. Wong
2013-10-18 18:39 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1310231648450.1918@localhost.localdomain \
--to=lczerner@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox