From: "Lukáš Czerner" <lczerner@redhat.com>
To: Namjae Jeon <linkinjeon@gmail.com>
Cc: tytso@mit.edu, Namjae Jeon <namjae.jeon@samsung.com>,
linux-kernel@vger.kernel.org, xfs@oss.sgi.com, bpm@sgi.com,
adilger.kernel@dilger.ca, viro@zeniv.linux.org.uk,
Ashish Sangwan <a.sangwan@samsung.com>,
linux-fsdevel@vger.kernel.org, jack@suse.cz,
linux-ext4@vger.kernel.org, mtk.manpages@gmail.com
Subject: Re: [PATCH RESEND 3/10] ext4: Add support FALLOC_FL_COLLAPSE_RANGE for fallocate
Date: Tue, 18 Feb 2014 10:05:49 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.2.00.1402181001530.2216@localhost.localdomain> (raw)
In-Reply-To: <CAKYAXd-bD6ZZgpc9E8V1kD9Dj2wrCkbi1i6drNBdUAwsMiv5gg@mail.gmail.com>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 2318 bytes --]
On Wed, 12 Feb 2014, Namjae Jeon wrote:
> Date: Wed, 12 Feb 2014 11:28:35 +0900
> From: Namjae Jeon <linkinjeon@gmail.com>
> To: Lukáš Czerner <lczerner@redhat.com>
> Cc: viro@zeniv.linux.org.uk, david@fromorbit.com, bpm@sgi.com, tytso@mit.edu,
> adilger.kernel@dilger.ca, jack@suse.cz, mtk.manpages@gmail.com,
> linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com,
> linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
> Namjae Jeon <namjae.jeon@samsung.com>,
> Ashish Sangwan <a.sangwan@samsung.com>
> Subject: Re: [PATCH RESEND 3/10] ext4: Add support FALLOC_FL_COLLAPSE_RANGE
> for fallocate
>
> 2014-02-11 20:59 GMT+09:00, Lukáš Czerner <lczerner@redhat.com>:
> > On Sun, 2 Feb 2014, Namjae Jeon wrote:
> >
> >> Date: Sun, 2 Feb 2014 14:44:34 +0900
> >> From: Namjae Jeon <linkinjeon@gmail.com>
> >> To: viro@zeniv.linux.org.uk, david@fromorbit.com, bpm@sgi.com,
> >> tytso@mit.edu,
> >> adilger.kernel@dilger.ca, jack@suse.cz, mtk.manpages@gmail.com
> >> Cc: linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com,
> >> linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
> >> Namjae Jeon <linkinjeon@gmail.com>, Namjae Jeon
> >> <namjae.jeon@samsung.com>,
> >> Ashish Sangwan <a.sangwan@samsung.com>
> >> Subject: [PATCH RESEND 3/10] ext4: Add support FALLOC_FL_COLLAPSE_RANGE
> >> for
> >> fallocate
> >>
> >> From: Namjae Jeon <namjae.jeon@samsung.com>
> >>
> >> Add support FALLOC_FL_COLLAPSE_RANGE for fallocate
> Hi Lukas.
> >
> > Description is missing here, please provide FALLOC_FL_COLLAPSE_RANGE
> > description so people know what it's supposed to be doing.
> >
> > more comments bellow.
> Okay, I will udpate.
> >
> > Thanks!
> > -Lukas
Hi,
you may have noticed my patches for new FALLOC_FL_ZERO_RANGE
fallocate flag. This changes things around the same area as your
patches does so we should probably figure out which are going to
land in first and then rebase the other on top of that.
One concern I have is that I have not seen any tests provided to
verify the feature. But I just may have missed it. Do you have any
xfstests test or at least fsx and fsstress patches to provide
support for testing FALLOC_FL_COLLAPSE_RANGE ? Patches for
util_linux might also be handy.
Thanks!
-Lukas
[-- Attachment #2: Type: text/plain, Size: 121 bytes --]
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-02-18 9:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-02 5:44 [PATCH RESEND 3/10] ext4: Add support FALLOC_FL_COLLAPSE_RANGE for fallocate Namjae Jeon
2014-02-10 23:34 ` Dave Chinner
2014-02-11 11:59 ` Lukáš Czerner
2014-02-12 2:28 ` Namjae Jeon
2014-02-18 9:05 ` Lukáš Czerner [this message]
2014-02-18 9:46 ` Dave Chinner
2014-02-18 9:50 ` Namjae Jeon
2014-02-18 14:30 ` Theodore Ts'o
2014-02-19 1:08 ` Namjae Jeon
2014-02-25 19:08 ` [PATCH] util-linux/fallocate: introduce an option -c to support FALLOC_FL_COLLAPSE_RANGE Dongsu Park
2014-02-25 19:31 ` Dave Chinner
2014-02-27 10:27 ` Dongsu Park
2014-02-27 3:59 ` Namjae Jeon
2014-02-27 10:35 ` [PATCH v2] util-linux/fallocate: introduce an option -c to support COLLAPSE_RANGE Dongsu Park
2014-04-18 10:52 ` Karel Zak
2014-02-27 9:00 ` [PATCH] util-linux/fallocate: introduce an option -c to support FALLOC_FL_COLLAPSE_RANGE Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1402181001530.2216@localhost.localdomain \
--to=lczerner@redhat.com \
--cc=a.sangwan@samsung.com \
--cc=adilger.kernel@dilger.ca \
--cc=bpm@sgi.com \
--cc=jack@suse.cz \
--cc=linkinjeon@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=namjae.jeon@samsung.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).