From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-15?Q?Luk=E1=A8_Czerner?= Subject: Re: [PATCH 6/6] ext4/242: Add ext4 specific test for fallocate zero range Date: Wed, 26 Feb 2014 15:24:18 +0100 (CET) Message-ID: References: <1393355728-12056-1-git-send-email-lczerner@redhat.com> <1393355728-12056-6-git-send-email-lczerner@redhat.com> <20140225205349.GD13647@dastard> <20140225215011.GF13647@dastard> Mime-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323328-1156906821-1393424660=:2243" Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, xfs@oss.sgi.com To: Dave Chinner Return-path: In-Reply-To: <20140225215011.GF13647@dastard> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com List-Id: linux-ext4.vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323328-1156906821-1393424660=:2243 Content-Type: TEXT/PLAIN; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Wed, 26 Feb 2014, Dave Chinner wrote: > Date: Wed, 26 Feb 2014 08:50:11 +1100 > From: Dave Chinner > To: Luk=C3=A1=C5=A1 Czerner > Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, xfs@oss.= sgi.com > Subject: Re: [PATCH 6/6] ext4/242: Add ext4 specific test for fallocate= zero > range >=20 > On Tue, Feb 25, 2014 at 10:01:06PM +0100, Luk=C3=A1=C5=A1 Czerner wrote= : > > On Wed, 26 Feb 2014, Dave Chinner wrote: > >=20 > > > Date: Wed, 26 Feb 2014 07:53:49 +1100 > > > From: Dave Chinner > > > To: Lukas Czerner > > > Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, xfs@= oss.sgi.com > > > Subject: Re: [PATCH 6/6] ext4/242: Add ext4 specific test for fallo= cate zero > > > range > > >=20 > > > On Tue, Feb 25, 2014 at 08:15:28PM +0100, Lukas Czerner wrote: > > > > This is copy of xfs/242. However it's better to make it file syst= em > > > > specific because the range can be zeroes either directly by writi= ng > > > > zeroes, or converting to unwritten extent, so the actual result m= ight > > > > differ from file system to file system. > > >=20 > > > You could say the same thing about preallocation using unwritten > > > extents. Yet, funnily enough, we have generic tests for them becaus= e > > > all filesystems currently use unwritten extents for preallocation > > > and behave identically.... > > >=20 > > > This test is no different - all filesystems currently use unwritten > > > extents, and so this test should be generic because all existing > > > filesystems *should* behave the same. > > >=20 > > > When we get a filesystem that zeros rather uses unwritten extents, > > > we can add a new *generic* test that tests for zeroed data extents > > > rather than unwritten extents. All that we will need is a method of > > > checking what behaviour the filesystem has and adding that to a > > > _requires directive to ensure the correct generic fallocate tests > > > are run... > >=20 > > Currently xfs/242 fails on xfs for me >=20 > Really? Where's the bug report? I haven't seen a failure on xfs/242 > on any of my test machines for at least a year, even on 1k block > size filesystems... >=20 > $ sudo ./check xfs/242 > FSTYP -- xfs (debug) > PLATFORM -- Linux/x86_64 test2 3.14.0-rc3-dgc+ > MKFS_OPTIONS -- -f -bsize=3D4096 /dev/vdb > MOUNT_OPTIONS -- /dev/vdb /mnt/scratch >=20 > xfs/242 1s ... 0s > Ran: xfs/242 > Passed all 1 tests > $ Here it is. xfs/242 fails on ppc64 with latest linus tree # uname -a Linux ibm-p740-01-lp4.rhts.eng.bos.redhat.com 3.14.0-rc4+ #1 SMP Wed Feb 26 08:59:48 EST 2014 ppc64 ppc64 ppc64 GNU/Linux # ./check xfs/242 FSTYP -- xfs (non-debug) PLATFORM -- Linux/ppc64 ibm-p740-01-lp4 3.14.0-rc4+ MKFS_OPTIONS -- -f -bsize=3D4096 /dev/loop1 MOUNT_OPTIONS -- -o context=3Dsystem_u:object_r:nfs_t:s0 /dev/loop1 /mnt/= test2 xfs/242 - output mismatch (see /root/xfstests/results//xfs/242.out.bad) --- tests/xfs/242.out 2014-02-26 05:51:16.602579462 -0500 +++ /root/xfstests/results//xfs/242.out.bad 2014-02-26 09:20:55.58539= 6040 -0500 @@ -1,76 +1,71 @@ QA output created by 242 1. into a hole 0: [0..7]: hole -1: [8..23]: unwritten +1: [8..23]: data 2: [24..39]: hole daa100df6e6711906b61c9ab5aa16032 ... (Run 'diff -u tests/xfs/242.out /root/xfstests/results//xfs/242.out.b= ad' to see the entire diff) Ran: xfs/242 Failures: xfs/242 Failed 1 of 1 tests Here is 242.out.bad QA output created by 242 1. into a hole 0: [0..7]: hole 1: [8..23]: data 2: [24..39]: hole daa100df6e6711906b61c9ab5aa16032 2. into allocated space 0: [0..39]: data cc58a7417c2d7763adc45b6fcd3fa024 3. into unwritten space 0: [0..39]: unwritten daa100df6e6711906b61c9ab5aa16032 4. hole -> data 0: [0..7]: hole 1: [8..31]: data 2: [32..39]: hole cc63069677939f69a6e8f68cae6a6dac 5. hole -> unwritten 0: [0..7]: hole 1: [8..23]: data 2: [24..31]: unwritten 3: [32..39]: hole daa100df6e6711906b61c9ab5aa16032 6. data -> hole 0: [0..23]: data 1: [24..39]: hole 1b3779878366498b28c702ef88c4a773 7. data -> unwritten 0: [0..15]: data 1: [16..31]: unwritten 2: [32..39]: hole 1b3779878366498b28c702ef88c4a773 8. unwritten -> hole 0: [0..7]: unwritten 1: [8..23]: data 2: [24..39]: hole daa100df6e6711906b61c9ab5aa16032 9. unwritten -> data 0: [0..15]: unwritten 1: [16..31]: data 2: [32..39]: hole cc63069677939f69a6e8f68cae6a6dac 10. hole -> data -> hole 0: [0..7]: hole 1: [8..31]: data 2: [32..39]: hole daa100df6e6711906b61c9ab5aa16032 11. data -> hole -> data 0: [0..39]: data f6aeca13ec49e5b266cd1c913cd726e3 12. unwritten -> data -> unwritten 0: [0..15]: unwritten 1: [16..23]: data 2: [24..39]: unwritten daa100df6e6711906b61c9ab5aa16032 13. data -> unwritten -> data 0: [0..7]: data 1: [8..23]: unwritten 2: [24..39]: data f6aeca13ec49e5b266cd1c913cd726e3 14. data -> hole @ EOF 0: [0..39]: data e1f024eedd27ea6b1c3e9b841c850404 15. data -> hole @ 0 0: [0..39]: data eecb7aa303d121835de05028751d301c 16. data -> cache cold ->hole 0: [0..39]: data eecb7aa303d121835de05028751d301c 17. data -> hole in single block file 0: [0..7]: data 0000000 cdcd cdcd cdcd cdcd cdcd cdcd cdcd cdcd * 0000200 0000 0000 0000 0000 0000 0000 0000 0000 * 0000400 cdcd cdcd cdcd cdcd cdcd cdcd cdcd cdcd * --8323328-1156906821-1393424660=:2243 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs --8323328-1156906821-1393424660=:2243--